Bug 13613: (follow-up) Add tooltip when disabled

This patch adds a tooltip to the digest checkboxes when disabled.

When enabled the tooltip is hidden

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc
index 9340384..1d50856 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc
@@ -187,24 +187,24 @@
                 <input type="checkbox"
                      id="digest[% messaging_preference.message_attribute_id | html %]"
                      value="[% messaging_preference.message_attribute_id | html %]"
-                     name="digest" class="pmp_digest" checked="checked" disabled="disabled" />
+                     name="digest" class="pmp_digest" checked="checked" disabled="disabled" data-toggle="tooltip" title="You must select a digestible transport to select digests" />
               [% ELSE %]
                 <input type="checkbox"
                      id="digest[% messaging_preference.message_attribute_id | html %]"
                      value="[% messaging_preference.message_attribute_id | html %]"
-                     name="digest" class="pmp_digest" disabled="disabled" />
+                     name="digest" class="pmp_digest" disabled="disabled" data-toggle="tooltip" title="You must select a digestible transport to select digests" />
               [% END %]
           [% ELSE %]
               [% IF ( messaging_preference.digest ) %]
                 <input type="checkbox"
                      id="digest[% messaging_preference.message_attribute_id | html %]"
                      value="[% messaging_preference.message_attribute_id | html %]"
-                     name="digest" checked="checked" class="pmp_digest active_notify" data-attr-id="[% messaging_preference.message_attribute_id | html %]" />
+                     name="digest" checked="checked" class="pmp_digest active_notify" data-attr-id="[% messaging_preference.message_attribute_id | html %]" data-toggle="tooltip" title="You must select a digestible transport to select digests" />
               [% ELSE %]
                 <input type="checkbox"
                      id="digest[% messaging_preference.message_attribute_id | html %]"
                      value="[% messaging_preference.message_attribute_id | html %]"
-                     name="digest" class="pmp_digest active_notify" data-attr-id="[% messaging_preference.message_attribute_id | html %]" />
+                     name="digest" class="pmp_digest active_notify" data-attr-id="[% messaging_preference.message_attribute_id | html %]" data-toggle="tooltip" title="You must select a digestible transport to select digests" />
               [% END %]
           [% END %]
       </td>

diff --git a/koha-tmpl/intranet-tmpl/prog/js/messaging-preference-form.js b/koha-tmpl/intranet-tmpl/prog/js/messaging-preference-form.js
index 0196d6e..716019b 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/js/messaging-preference-form.js
+++ b/koha-tmpl/intranet-tmpl/prog/js/messaging-preference-form.js
@@ -53,9 +53,9 @@ $(document).ready(function(){
         var rowid = $(this).attr("id");
         id = Number(rowid.replace("email",""));
         if ( $("#email"+id).prop("checked") || $("#sms"+id).prop("checked") ) {
-            $("#digest"+id).attr("disabled", false);
+            $("#digest"+id).attr("disabled", false).tooltip('disable');
         } else {
-            $("#digest"+id).attr("disabled", true).prop("checked",false);
+            $("#digest"+id).attr("disabled", true).prop("checked",false).tooltip('enable');
         }
     });
 
@@ -64,18 +64,20 @@ $(document).ready(function(){
         var rowid = $(this).attr("id");
         id = Number(rowid.replace("email",""));
         if ( $("#email"+id).prop("checked") || $("#sms"+id).prop("checked") ) {
-            $("#digest"+id).attr("disabled", false);
+            $("#digest"+id).attr("disabled", false).tooltip('disable');
         } else {
-            $("#digest"+id).attr("disabled", true).prop("checked",false);
+            $("#digest"+id).attr("disabled", true).prop("checked",false).tooltip('enable');
         }
     });
     $(".pmp_sms").click(function(){
         var rowid = $(this).attr("id");
         id = Number(rowid.replace("sms",""));
         if ( $("#email"+id).prop("checked") || $("#sms"+id).prop("checked") ) {
-            $("#digest"+id).attr("disabled", false);
+            $("#digest"+id).attr("disabled", false).tooltip('disable');
         } else {
-            $("#digest"+id).attr("disabled", true).prop("checked",false);
+            $("#digest"+id).attr("disabled", true).prop("checked",false).tooltip('enable');
         }
     });
+
+//    $('#memberentry_messaging_prefs [data-toggle="tooltip"][disabled]').tooltip();
 });

diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt
index a8c7149..ef9e266 100644 (file)
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt
@@ -156,9 +156,9 @@
                                             [% IF ( messaging_preference.has_digest ) %]
                                                 <td class="selectcol">
                                                     [% IF ( messaging_preference.digest ) %]
-                                                        <input type="checkbox" id="digest[% messaging_preference.message_attribute_id | html %]" value="[% messaging_preference.message_attribute_id | html %]" name="digest" checked="checked" />
+                                                        <input type="checkbox" id="digest[% messaging_preference.message_attribute_id | html %]" value="[% messaging_preference.message_attribute_id | html %]" name="digest" checked="checked" data-toggle="tooltip" title="You must select a digestible transport to select digests" />
                                                     [% ELSE %]
-                                                        <input type="checkbox" id="digest[% messaging_preference.message_attribute_id | html %]" value="[% messaging_preference.message_attribute_id | html %]" name="digest" />
+                                                        <input type="checkbox" id="digest[% messaging_preference.message_attribute_id | html %]" value="[% messaging_preference.message_attribute_id | html %]" name="digest" data-toggle="tooltip" title="You must select a digestible transport to select digests" />
                                                     [% END %]
                                                 </td>
                                             [% ELSE %]
@@ -255,9 +255,9 @@
                 var rowid = $(this).attr("id");
                 id = Number(rowid.replace("email",""));
                 if ( $("#email"+id).prop("checked") || $("#sms"+id).prop("checked") ) {
-                    $("#digest"+id).attr("disabled", false);
+                    $("#digest"+id).attr("disabled", false).tooltip('disable');
                 } else {
-                    $("#digest"+id).attr("disabled", true);
+                    $("#digest"+id).attr("disabled", true).tooltip('enable');
                 }
             });
 
@@ -266,18 +266,18 @@
                 var rowid = $(this).attr("id");
                 id = Number(rowid.replace("email",""));
                 if ( $("#email"+id).prop("checked") || $("#sms"+id).prop("checked") ) {
-                    $("#digest"+id).attr("disabled", false);
+                    $("#digest"+id).attr("disabled", false).tooltip('disable');
                 } else {
-                    $("#digest"+id).attr("disabled", true).prop("checked",false);
+                    $("#digest"+id).attr("disabled", true).prop("checked",false).tooltip('enable');
                 }
             });
             $(".pmp_sms").click(function(){
                 var rowid = $(this).attr("id");
                 id = Number(rowid.replace("sms",""));
                 if ( $("#email"+id).prop("checked") || $("#sms"+id).prop("checked") ) {
-                    $("#digest"+id).attr("disabled", false);
+                    $("#digest"+id).attr("disabled", false).tooltip('disable');
                 } else {
-                    $("#digest"+id).attr("disabled", true).prop("checked",false);
+                    $("#digest"+id).attr("disabled", true).prop("checked",false).tooltip('enable');
                 }
             });
         });