Bug 21105: (QA follow-up) Silence warning because of tests setup
authorTomas Cohen Arazi <tomascohen@theke.io>
Fri, 12 Nov 2021 14:15:08 +0000 (11:15 -0300)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 15 Nov 2021 11:38:39 +0000 (12:38 +0100)
The tests are using 'http://localhost' and the regex is setting $baseURL
to empty in this case. It works on the oai.pl front-end.

This patch changes the regex.

To test:
1. Run:
   $ kshell
  k$ t/db_dependent/OAI/Server.t
=> FAIL: Boo! Warning!
2. Apply this patch
3. Repeat 2
=> SUCCESS: Oh, cool. No warning :-D
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Koha/OAI/Server/Identify.pm

index 7afccef..a44df73 100644 (file)
@@ -28,7 +28,10 @@ use base ("HTTP::OAI::Identify");
 sub new {
     my ($class, $repository) = @_;
 
-    my ($baseURL) = $repository->self_url() =~ /(.*)\?.*/;
+    my $baseURL = $repository->self_url();
+    $baseURL = $+{base_url}
+        if $baseURL =~ m/(?<base_url>.*)\?.*/;
+
     my $self = $class->SUPER::new(
         baseURL             => $baseURL,
         repositoryName      => C4::Context->preference("LibraryName"),