Bug 7843: (qa-followup) Create an RSS feed for news in Opac

1/ use strict and warnings are useless, Modern::Perl is used
2/ Prefer to use the interface and theme TT var instead of the hard
coded path

Signed-off-by: Pierre <tredok.pierre@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>

diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt
index 5dd7955..ca86c22 100644 (file)
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt
@@ -48,7 +48,7 @@
                 [% END %]
             </div>
             <div id="rssnews-container">
-                <a href="opac-news-rss.pl"><img src="/opac-tmpl/bootstrap/images/feed-icon-16x16.png"></a>
+                <a href="opac-news-rss.pl"><img src="[% interface %]/[% theme %]/images/feed-icon-16x16.png"></a>
                 RSS for the librarys general newsfeed.
             </div>
         [% END %]

diff --git a/opac/opac-news-rss.pl b/opac/opac-news-rss.pl
index 5250a74..d48fceb 100755 (executable)
--- a/opac/opac-news-rss.pl
+++ b/opac/opac-news-rss.pl
@@ -25,10 +25,6 @@ use C4::Output;
 use C4::NewsChannels;    # GetNewsToDisplay
 use C4::Languages qw(getTranslatedLanguages accept_language);
 
-use strict;
-use warnings;
-
-
 my $input = new CGI;
 my $dbh   = C4::Context->dbh;