Bug 15959: Use Font Awesome icons for attach item confirmations

When attaching an existing item to a record, the confirmation and error
dialogs should be styled using Font Awesome icons. This patch revises
the buttons and revises the global CSS file.

To test, apply the patch and clear your cache if necessary.

- Locate a record in the catalog to which you can attach an item.
- Select "Attach item" from the "Edit" menu.
- Submit a barcode for an exising item.
- Verify that the confirmation dialog is correctly styled.
  - Test the operation of both the "OK" and the "Attach another item"
    buttons.
- Submit an invalid barcode.
- Verify that the error dialog is correctly styled.
  - Test the operation of both the "OK" and the "Try again"
    buttons.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as described

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>

diff --git a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
index 2328304..8abb9ee 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
+++ b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
@@ -1217,6 +1217,10 @@ div.alert strong {
     color: #cc0000;
 }
 
+.new i.fa {
+    color: #425FAF;
+}
+
 a.clear-field {
     background : transparent url("../../img/clear-field.png") center left no-repeat;
     padding-left : 16px;

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/moveitem.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/moveitem.tt
index e998929..f11dc7d 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/moveitem.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/moveitem.tt
@@ -21,11 +21,11 @@
 [% END %]
 
 [% BLOCK fail %]
-                                <input type="submit" class="approve" value="OK" />
+        <button type="submit" class="approve"><i class="fa fa-fw fa-check"></i> OK</button>
                                 <input type="hidden" name="biblionumber" value="[% biblionumber %]" />
                         </form>
                                 <form method="get" action="/cgi-bin/koha/cataloguing/moveitem.pl?biblionumber=[% biblionumber %]">
-                                <input type="submit" class="new" value="Try again with a different barcode"/>
+        <button type="submit" class="new"><i class="fa fa-fw fa-plus"></i> Try again with a different barcode</button>
                                 <input type="hidden" name="biblionumber" value="[% biblionumber %]" />
                         </form>
 [% END %]
@@ -55,11 +55,11 @@
                        <div class="dialog message">The item has successfully been attached to [% INCLUDE 'biblio-default-view.inc' %]<i>[% bibliotitle |html %]</i></a>.
                        <p>
                        [% INCLUDE actions %]
-                               <input type="submit" class="approve" value="OK" />
+                    <button type="submit" class="approve"><i class="fa fa-fw fa-check"></i> OK</button>
                                 <input type="hidden" name="biblionumber" value="[% biblionumber %]" />
                         </form>
                                 <form method="get" action="/cgi-bin/koha/cataloguing/moveitem.pl?biblionumber=[% biblionumber %]"/>
-                                <input type="submit" class="new" value="Attach another item"/>
+                    <button type="submit" class="new"><i class="fa fa-fw fa-plus"></i> Attach another item</button>
                                 <input type="hidden" name="biblionumber" value="[% biblionumber %]" />
                         </form>
                        </p>