Bug 26963: (follow-up) Change subroutine name for QA tools

It didn't like the ending _at

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

diff --git a/Koha/Item.pm b/Koha/Item.pm
index 9766d8b..71f6b78 100644 (file)
--- a/Koha/Item.pm
+++ b/Koha/Item.pm
@@ -553,9 +553,9 @@ sub can_be_transferred {
 
 }
 
-=head3 _can_pickup_at
+=head3 _can_pickup_locations
 
-$item->_can_pickup_at({ to => $to_libraries, from => $from_library })
+$item->_can_pickup_locations({ to => $to_libraries, from => $from_library })
 Checks if an item can be transferred to given libraries.
 
 This feature is controlled by two system preferences:
@@ -577,7 +577,7 @@ If checking only one library please use $item->can_be_transferred.
 
 =cut
 
-sub _can_pickup_at {
+sub _can_pickup_locations {
     my ($self, $params ) = @_;
 
     my $to   = $params->{to};
@@ -658,7 +658,7 @@ sub pickup_locations {
         })->as_list;
     }
 
-    my $pickup_locations = $self->_can_pickup_at({
+    my $pickup_locations = $self->_can_pickup_locations({
         to => \@libs
     });
 

diff --git a/t/db_dependent/Koha/Item.t b/t/db_dependent/Koha/Item.t
index d244160..e8fd36a 100755 (executable)
--- a/t/db_dependent/Koha/Item.t
+++ b/t/db_dependent/Koha/Item.t
@@ -339,7 +339,7 @@ subtest 'pickup_locations' => sub {
     $schema->storage->txn_rollback;
 };
 
-subtest '_can_pickup_at' => sub {
+subtest '_can_pickup_locations' => sub {
     plan tests =>8;
 
     $schema->storage->txn_begin;
@@ -359,7 +359,7 @@ subtest '_can_pickup_at' => sub {
 
     my @to = ( $library1, $library2, $library3, $library4 );
 
-    my $pickup_locations = $item->_can_pickup_at({ to => \@to });
+    my $pickup_locations = $item->_can_pickup_locations({ to => \@to });
     is( scalar @$pickup_locations, 3, "With no transfer limits we get back the libraries that are pickup locations");
 
     t::lib::Mocks::mock_preference('UseBranchTransferLimits', 1);
@@ -372,7 +372,7 @@ subtest '_can_pickup_at' => sub {
         }
     });
 
-    $pickup_locations = $item->_can_pickup_at({ to => \@to });
+    $pickup_locations = $item->_can_pickup_locations({ to => \@to });
     is( scalar @$pickup_locations, 2, "With a transfer limits we get back the libraries that are pickup locations minus 1 limited library");
 
     $builder->build_object( { class => 'Koha::Item::Transfer::Limits', value => {
@@ -383,11 +383,11 @@ subtest '_can_pickup_at' => sub {
         }
     });
 
-    $pickup_locations = $item->_can_pickup_at({ to => \@to });
+    $pickup_locations = $item->_can_pickup_locations({ to => \@to });
     is( scalar @$pickup_locations, 1, "With 2 transfer limits we get back the libraries that are pickup locations minus 2 limited libraries");
 
     t::lib::Mocks::mock_preference('BranchTransferLimitsType', 'ccode');
-    $pickup_locations = $item->_can_pickup_at({ to => \@to });
+    $pickup_locations = $item->_can_pickup_locations({ to => \@to });
     is( scalar @$pickup_locations, 3, "With no transfer limits of type ccode we get back the libraries that are pickup locations");
 
     $builder->build_object( { class => 'Koha::Item::Transfer::Limits', value => {
@@ -398,7 +398,7 @@ subtest '_can_pickup_at' => sub {
         }
     });
 
-    $pickup_locations = $item->_can_pickup_at({ to => \@to });
+    $pickup_locations = $item->_can_pickup_locations({ to => \@to });
     is( scalar @$pickup_locations, 2, "With a transfer limits we get back the libraries that are pickup locations minus 1 limited library");
 
     $builder->build_object( { class => 'Koha::Item::Transfer::Limits', value => {
@@ -409,16 +409,16 @@ subtest '_can_pickup_at' => sub {
         }
     });
 
-    $pickup_locations = $item->_can_pickup_at({ to => \@to });
+    $pickup_locations = $item->_can_pickup_locations({ to => \@to });
     is( scalar @$pickup_locations, 1, "With 2 transfer limits we get back the libraries that are pickup locations minus 2 limited libraries");
 
 
-    $pickup_locations = $item->_can_pickup_at({ to => \@to, from => $library2 });
+    $pickup_locations = $item->_can_pickup_locations({ to => \@to, from => $library2 });
     is( scalar @$pickup_locations, 3, "With transfer limits enabled but not applying because of 'from' we get back the libraries that are pickup locations");
 
     t::lib::Mocks::mock_preference('UseBranchTransferLimits', 0);
 
-    $pickup_locations = $item->_can_pickup_at({ to => \@to });
+    $pickup_locations = $item->_can_pickup_locations({ to => \@to });
     is( scalar @$pickup_locations, 3, "With transfer limits disabled we get back the libraries that are pickup locations");
 
 };