Bug 32831: Fix cataloguing/value_builder/unimarc_field_117.pl
authorJulian Maurice <julian.maurice@biblibre.com>
Fri, 3 Feb 2023 10:58:52 +0000 (11:58 +0100)
committerTomas Cohen Arazi <tomascohen@theke.io>
Mon, 27 Mar 2023 09:29:53 +0000 (11:29 +0200)
Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
cataloguing/value_builder/unimarc_field_117.pl

index 9286826..250f9a0 100755 (executable)
@@ -32,9 +32,10 @@ sub plugin_javascript {
 my ($dbh,$record,$tagslib,$field_number) = @_;
 my $res="
 <script>
-function Clic$field_number(i) {
-       defaultvalue=document.getElementById(\"$field_number\").value;
-       newin=window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_117.pl&index=$field_number&result=\"+defaultvalue,\"unimarc_field_117\",'width=600,height=225,toolbar=false,scrollbars=yes');
+function Clic$field_number(event) {
+    event.preventDefault();
+    defaultvalue=document.getElementById(event.data.id).value;
+    newin=window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_117.pl&index=\" + event.data.id + \"&result=\"+defaultvalue,\"unimarc_field_117\",'width=600,height=225,toolbar=false,scrollbars=yes');
 
 }
 </script>