Bug 29283: (QA follow-up) Remove code duplication
authorJoonas Kylmälä <joonas.kylmala@iki.fi>
Sun, 31 Oct 2021 12:22:06 +0000 (12:22 +0000)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 2 Nov 2021 13:57:09 +0000 (14:57 +0100)
We have already a search filter for active orders.

Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
acqui/basket.pl

index 3694348..1a2b275 100755 (executable)
@@ -127,9 +127,7 @@ if ( $op eq 'delete_confirm' ) {
     my $delbiblio  = $query->param('delbiblio');
     my $basket_obj = Koha::Acquisition::Baskets->find($basketno);
 
-    my $orders = $basket_obj->orders->search({
-        datecancellationprinted => undef
-    });
+    my $orders = $basket_obj->orders->filter_by_current;
 
     my @cannotdelbiblios;