Bug 16492: Add a FIXME to explain the possible problem with no_set_userenv
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 8 Jun 2016 14:32:31 +0000 (15:32 +0100)
committerKyle M Hall <kyle@bywatersolutions.com>
Fri, 10 Jun 2016 17:31:19 +0000 (17:31 +0000)
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
C4/Auth.pm

index a5cf72c..985bd39 100644 (file)
@@ -1737,6 +1737,11 @@ sub get_session {
     return $session;
 }
 
+
+# FIXME no_set_userenv may be replaced with force_branchcode_for_userenv
+# (or something similar)
+# Currently it's only passed from C4::SIP::ILS::Patron::check_password, but
+# not having a userenv defined could cause a crash.
 sub checkpw {
     my ( $dbh, $userid, $password, $query, $type, $no_set_userenv ) = @_;
     $type = 'opac' unless $type;