Bug 32535: Exclude flags from BorrowerUnwantedField system preference
authorKatrin Fischer <katrin.fischer.83@web.de>
Wed, 28 Dec 2022 20:36:33 +0000 (20:36 +0000)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Wed, 18 Jan 2023 15:47:13 +0000 (15:47 +0000)
The system preference BorrowerUnwantedField includes a checkbox
for "System permissions (flags)." Checking it has no apparent effect;
one is still able to edit patron permissions with the box checked.
This patch excludes the field from the selectable fields.

To test:
* Search for the BorrowerUnwantedField system prefernce
* Verify that you can check/uncheck System permissions (flags)
* Verify it doesn't have any effect, as permissions are not set
  from the patron edit form, but separately
* Apply patch
* Verify you no longer can check/uncheck the field in the
  system preference

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref

index fd91a85..25f6c27 100644 (file)
@@ -237,7 +237,7 @@ Patrons:
          - pref: BorrowerUnwantedField
            type: modalselect
            source: borrowers
-           exclusions: branchcode|categorycode
+           exclusions: branchcode|categorycode|flags
      -
          - "Borrowers can have the following titles:"
          - pref: BorrowersTitles