Bug 16942 [QA Followup] - Add unit test

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

diff --git a/C4/Reserves.pm b/C4/Reserves.pm
index afdcb48..c9e270c 100644 (file)
--- a/C4/Reserves.pm
+++ b/C4/Reserves.pm
@@ -2026,7 +2026,7 @@ sub _koha_notify_reserve {
             'biblio'         => $biblionumber,
             'biblioitems'    => $biblionumber,
             'reserves'       => $reserve,
-            'items', $reserve->{'itemnumber'},
+            'items'          => $reserve->{'itemnumber'},
         },
         substitute => { today => output_pref( { dt => dt_from_string, dateonly => 1 } ) },
     );

diff --git a/t/db_dependent/Letters/TemplateToolkit.t b/t/db_dependent/Letters/TemplateToolkit.t
index c4ecc5f..4169556 100644 (file)
--- a/t/db_dependent/Letters/TemplateToolkit.t
+++ b/t/db_dependent/Letters/TemplateToolkit.t
@@ -18,7 +18,7 @@
 # along with Koha; if not, see <http://www.gnu.org/licenses>.
 
 use Modern::Perl;
-use Test::More tests => 13;
+use Test::More tests => 14;
 
 use MARC::Record;
 
@@ -188,6 +188,23 @@ $prepared_letter = GetPreparedLetter(
 );
 is( $prepared_letter->{content}, $hold->id(), 'Hold object used correctly' );
 
+# Bug 16942
+$prepared_letter = GetPreparedLetter(
+    (
+        module      => 'test',
+        letter_code => 'TEST_HOLD',
+        tables      => {
+            'branches'    => $library,
+            'borrowers'   => $patron,
+            'biblio'      => $biblio->id,
+            'biblioitems' => $biblioitem->id,
+            'reserves'    => $hold->unblessed,
+            'items'       => $hold->itemnumber,
+        }
+    )
+);
+is( $prepared_letter->{content}, $hold->id(), 'Hold object used correctly' );
+
 $sth->execute( "TEST_SERIAL", "[% serial.id %]" );
 $prepared_letter = GetPreparedLetter(
     (