Bug 17578: GetMemberDetails - Remove reservefee

Same as other patches, reservefee is only used in opac-reserve.pl

Test plan;
Set reserve fee for a patron category
Place a hold at the OPAC with one of these patrons.
You must get a message about the reserve fee.

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

diff --git a/C4/Members.pm b/C4/Members.pm
index b64ccb8..9a8d5fc 100644 (file)
--- a/C4/Members.pm
+++ b/C4/Members.pm
@@ -146,7 +146,6 @@ sub GetMemberDetails {
             SELECT borrowers.*,
                    category_type,
                    categories.description,
-                   reservefee,
                    enrolmentperiod
             FROM borrowers
             LEFT JOIN categories ON borrowers.categorycode=categories.categorycode
@@ -159,7 +158,6 @@ sub GetMemberDetails {
             SELECT borrowers.*,
                    category_type,
                    categories.description,
-                   reservefee,
                    enrolmentperiod
             FROM borrowers
             LEFT JOIN categories ON borrowers.categorycode = categories.categorycode

diff --git a/opac/opac-reserve.pl b/opac/opac-reserve.pl
index a725730..7363236 100755 (executable)
--- a/opac/opac-reserve.pl
+++ b/opac/opac-reserve.pl
@@ -85,8 +85,9 @@ if ( $patron->category->effective_BlockExpiredPatronOpacActions ) {
 }
 
 # Pass through any reserve charge
-if ($borr->{reservefee} > 0){
-    $template->param( RESERVE_CHARGE => sprintf("%.2f",$borr->{reservefee}));
+my $reservefee = $patron->category->reservefee;
+if ( $reservefee > 0){
+    $template->param( RESERVE_CHARGE => sprintf("%.2f",$reservefee));
 }
 
 my $itemTypes = GetItemTypes();