Bug 25842: Fix typo streetype in member-main-address-style.inc
authorFridolin Somers <fridolin.somers@biblibre.com>
Tue, 23 Jun 2020 07:25:33 +0000 (09:25 +0200)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 23 Jun 2020 08:16:14 +0000 (10:16 +0200)
There are several more instances of the incorrect variable "streetype" in member-main-address-style.inc. Must be corrected with DB column name "streettype" in order to be able to set this field as mandatory.

See also :
Bug 25839 - Typo patron.streetype in member-main-address-style.inc

Test plan :
1) Add "streettype" in system preference "BorrowerMandatoryField"
2) Create a new patron
3) Without patch "Street type" field is not mandatory/required, with
   patch it is
4) Remove "streettype" from system preference "BorrowerMandatoryField"
5) Create a new patron
6) Check "Street type" field is not mandatory/required
7) Select a value and save
8) Edit again patron
9) Check value is selected

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style.inc

index edee601..bd384ed 100644 (file)
 [% BLOCK 'address-style_roadtypes' %]
     [% IF roadtypes %]
         <li>
-            [% IF ( mandatorystreetype ) %]
-                <label for="streetype" class="required">
+            [% IF ( mandatorystreettype ) %]
+                <label for="streettype" class="required">
             [% ELSE %]
-                <label for="streetype">
+                <label for="streettype">
             [% END %]
             Street type: </label>
-            <select name="streetype">
+            <select name="streettype">
                 <option value=""></option>
                 [% FOR roadtype IN roadtypes %]
                     [% IF roadtype.authorised_value == patron.streettype %]
@@ -64,7 +64,7 @@
                     [% END %]
                 [% END %]
             </select>
-            [% IF ( mandatorystreetype ) %]<span class="required">Required</span>[% END %]
+            [% IF ( mandatorystreettype ) %]<span class="required">Required</span>[% END %]
         </li>
     [% END %]
 [% END %]