Bug 31028: (follow-up) Rename TICKET_ACKNOWLEDGE
authorMartin Renvoize <martin.renvoize@ptfs-europe.com>
Wed, 2 Nov 2022 08:34:35 +0000 (08:34 +0000)
committerTomas Cohen Arazi <tomascohen@theke.io>
Mon, 6 Mar 2023 14:23:17 +0000 (11:23 -0300)
TICKET_ACKNOWLEDGEMENT was too long for the database field size, drop
the 'MENT' to ensure it fits.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Koha/Ticket.pm
installer/data/mysql/atomicupdate/bug_31028.pl
installer/data/mysql/en/mandatory/sample_notices.yml

index f716304..f7693d7 100644 (file)
@@ -118,7 +118,7 @@ sub store {
         # Send patron acknowledgement
         my $acknowledgement_letter = C4::Letters::GetPreparedLetter(
             module      => 'catalog',
-            letter_code => 'TICKET_ACKNOWLEDGEMENT',
+            letter_code => 'TICKET_ACKNOWLEDGE',
             branchcode  => $self->reporter->branchcode,
             tables      => { tickets => $self->id }
         );
index 47a2c40..e322ab1 100644 (file)
@@ -89,10 +89,10 @@ return {
         $dbh->do(
             q{
                 INSERT IGNORE INTO letter(module,code,branchcode,name,is_html,title,content,message_transport_type)
-                VALUES ( 'catalog', 'TICKET_ACKNOWLEDGEMENT', '', 'Concern acknowledgement', '1', 'Catalog concern acknowledgement', "Dear [% INCLUDE 'patron-title.inc' patron => ticket.reporter %],\r\n\r\nThankyou for your report concerning [% INCLUDE 'biblio-title.inc' biblio=ticket.biblio link = 0 %].\r\n\r\nYou reported: \r\n[% ticket.body %]\r\n\r\nThankyou", 'email' );
+                VALUES ( 'catalog', 'TICKET_ACKNOWLEDGE', '', 'Concern acknowledgement', '1', 'Catalog concern acknowledgement', "Dear [% INCLUDE 'patron-title.inc' patron => ticket.reporter %],\r\n\r\nThankyou for your report concerning [% INCLUDE 'biblio-title.inc' biblio=ticket.biblio link = 0 %].\r\n\r\nYou reported: \r\n[% ticket.body %]\r\n\r\nThankyou", 'email' );
             }
         );
-        say $out "Added new notice 'TICKET_ACKNOWLEDGEMENT'";
+        say $out "Added new notice 'TICKET_ACKNOWLEDGE'";
 
         $dbh->do(
             q{
index 261a6df..f3befe2 100644 (file)
@@ -44,7 +44,7 @@ tables:
             - "Your library."
 
         - module: catalog
-          code: TICKET_ACKNOWLEDGEMENT
+          code: TICKET_ACKNOWLEDGE
           branchcode: ""
           name: "Concern acknowledgement"
           is_html: 1