Bug 12198: remove unnecessary call to GetMemberIssuesAndFines from guarantor search
authorKyle M Hall <kyle@bywatersolutions.com>
Tue, 6 May 2014 16:26:49 +0000 (12:26 -0400)
committerGalen Charlton <gmc@esilibrary.com>
Thu, 8 May 2014 16:16:39 +0000 (16:16 +0000)
The script members/guarantor_search.pl made the following call:
my ($od,$issue,$fines)=GetMemberIssuesAndFines($results->[$i]{'borrowerid'});

Not only does this call always fail because borrowerid is not a valid
key, but the results are never even used in the template!

Test Plan:
1) Apply this patch
2) Verify the gurantor search works as before,
   No changes in behavior should be noted

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
members/guarantor_search.pl

index 59ea5b1..42d36a7 100755 (executable)
@@ -71,7 +71,6 @@ if ($member ne ''){
 
        for (my $i=0; $i < $count; $i++){
        #find out stats
-       my ($od,$issue,$fines)=GetMemberIssuesAndFines($results->[$i]{'borrowerid'});
        my $guarantorinfo=uc($results->[$i]{'surname'})." , ".ucfirst($results->[$i]{'firstname'});
        my %row = (
                background => $background,
@@ -94,8 +93,6 @@ if ($member ne ''){
                dateofbirth =>format_date($results->[$i]{'dateofbirth'}),
                #fi op  
                
-               odissue => "$od/$issue",
-               fines => $fines,
                borrowernotes => $results->[$i]{'borrowernotes'});
        if ( $background ) { $background = 0; } else {$background = 1; }
        push(@resultsdata, \%row);