Bug 6084: Missing translation markers in javascript alert messages
authorTomas Cohen Arazi <tomascohen@gmail.com>
Thu, 7 Apr 2011 08:46:15 +0000 (10:46 +0200)
committerChris Cormack <chrisc@catalyst.net.nz>
Thu, 7 Apr 2011 09:46:45 +0000 (21:46 +1200)
I ommited commented lines and "if $debug" lines too.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
18 files changed:
koha-tmpl/intranet-tmpl/prog/en/includes/labels-batches-toolbar.inc
koha-tmpl/intranet-tmpl/prog/en/includes/patroncards-batches-toolbar.inc
koha-tmpl/intranet-tmpl/prog/en/js/xmlControlfield.js
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tmpl
koha-tmpl/intranet-tmpl/prog/en/modules/admin/biblio_framework.tmpl
koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tmpl
koha-tmpl/intranet-tmpl/prog/en/modules/admin/stopwords.tmpl
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tmpl
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/macles.tmpl
koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-batch.tmpl
koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-manage.tmpl
koha-tmpl/intranet-tmpl/prog/en/modules/offline_circ/process_koc.tmpl
koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/image-manage.tmpl
koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/manage.tmpl
koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tmpl
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-recieve.tmpl
koha-tmpl/intranet-tmpl/prog/en/modules/tools/cleanborrowers.tmpl
koha-tmpl/opac-tmpl/prog/en/modules/opac-review.tmpl

index f3a2006..77ee7d4 100644 (file)
@@ -22,7 +22,7 @@
                         }
                     }
                     if (items.length < 1) {
-                        alert("Please select at least one item to delete.");
+                        alert(_("Please select at least one item to delete."));
                         return;     // no item selected
                     }
                     getstr = items.join("&");
@@ -34,7 +34,7 @@
 //                    var msg = "Are you sure you want to remove selected item from this batch?"
 //                }
                 else {
-                    alert("Please select at least label to delete.");
+                    alert(_("Please select at least label to delete."));
                     return;     // no item selected
                 }
                 var answer = confirm(msg);
@@ -67,7 +67,7 @@
                             }
                         }
                         if (labels.length < 1) {
-                            alert("Please select at least one label to export.");
+                            alert(_("Please select at least one label to export."));
                             return;     // no batch selected
                         }
                         getstr = labels.join("&");
@@ -76,7 +76,7 @@
                         getstr = document.items.action.value;
                     }
                     else {
-                        alert("Please select at least one label to export.");
+                        alert(_("Please select at least one label to export."));
                         return;     // no batch selected
                     }
                     return GB_showCenter('Export Labels', "/cgi-bin/koha/labels/label-print.pl?batch_id=<!-- TMPL_VAR NAME="batch_id" -->&" + getstr, 700, 800);
                         return(document.items.action.value);
                     }
                 };
-                alert("Please select at least one item.");
+                alert(_("Please select at least one item."));
                 return (-1);
             };
 
index 80e552e..237c9aa 100644 (file)
@@ -22,7 +22,7 @@
                         }
                     }
                     if (items.length < 1) {
-                        alert("Please select at least one item to delete.");
+                        alert(_("Please select at least one item to delete."));
                         return;     // no item selected
                     }
                     getstr = items.join("&");
@@ -34,7 +34,7 @@
 //                    var msg = "Are you sure you want to remove selected item from this batch?"
 //                }
                 else {
-                    alert("Please select at least label to delete.");
+                    alert(_("Please select at least label to delete."));
                     return;     // no item selected
                 }
                 var answer = confirm(msg);
@@ -61,7 +61,7 @@
                             }
                         }
                         if (patroncards.length < 1) {
-                            alert("Please select at least one card to export.");
+                            alert(_("Please select at least one card to export."));
                             return;     // no batch selected
                         }
                         getstr = patroncards.join("&");
@@ -70,7 +70,7 @@
                         getstr = document.items.action.value;
                     }
                     else {
-                        alert("Please select at least one card to export.");
+                        alert(_("Please select at least one card to export."));
                         return;     // no batch selected
                     }
                     return GB_showCenter('Export Labels', "/cgi-bin/koha/patroncards/print.pl?batch_id=<!-- TMPL_VAR NAME="batch_id" -->&" + getstr, 700, 800);
@@ -95,7 +95,7 @@
                         return(document.items.action.value);
                     }
                 };
-                alert("Please select at least one item.");
+                alert(_("Please select at least one item."));
                 return (-1);
             };
 
index dca6e75..5acb5fd 100755 (executable)
@@ -209,7 +209,7 @@ function changeH4Result(form, h4_result, tr_result, pos, value)
             }).responseXML;
             if (this.xmlDoc) this.renderTemplate();
             $("*").ajaxError(function(evt, request, settings){
-                alert("AJAX error: receiving data from " + settings.url);
+                alert(_("AJAX error: receiving data from ") + settings.url);
             });
         },//loadXmlValues
 
index d8b34ce..52e9dc7 100644 (file)
@@ -78,13 +78,13 @@ $(document).ready(function()
             // if user decreases the quantity
             if($(this).val() < <!-- TMPL_VAR name="quantityrec" -->) 
             {
-                alert("You have deleted item(s) in the order, don't forget to delete it(them) in the catalog");   
+                alert(_("You have deleted item(s) in the order, don't forget to delete it(them) in the catalog"));
                 return true;
             } 
             else 
             {
                 // if user increases the quantity
-                alert("You can't add a new item, please create a new order line");
+                alert(_("You can't add a new item, please create a new order line"));
                 // and we replace the original value
                 $(this).val(<!-- TMPL_VAR name="quantityrec" -->)
                 return false;
index 860f57a..8d979e8 100755 (executable)
@@ -73,7 +73,7 @@ $(document).ready(function() {
 
         var matches = new RegExp("\\?error_import_export=(.+)$").exec(window.location.search);
         if (matches && matches.length > 1) {
-            alert("Error importing the framework " + decodeURIComponent(matches[1]));
+            alert(_("Error importing the framework ") + decodeURIComponent(matches[1]));
         }
     });
     
index dbe2612..8b4aaa9 100644 (file)
@@ -13,7 +13,7 @@
 //<![CDATA[
     function Check(f) {
         if (f.city_zipcode.value.length == 0 && f.city_name.value.length == 0 ) {
-            alert("City name & zipcode missing");
+            alert(_("City name & zipcode missing"));
         } else{
             document.Aform.submit();
         }
index 6fc0148..9a63fe6 100644 (file)
@@ -19,7 +19,7 @@
     }
     function Check(f) {
         if (f.word.value.length==0) {
-            alert("Form not submitted: word missing");
+            alert(_("Form not submitted: word missing"));
         } else {
             document.Aform.submit();
         }
index 6a32740..3cda858 100644 (file)
@@ -160,7 +160,7 @@ $(document).ready(function() {
 });
 
 function set_to_today(id, force) {
-    if (! id) { alert("Bad id " + id + " sent to set_to_today()"); return 0; }
+    if (! id) { alert(_("Bad id ") + id + _(" sent to set_to_today()")); return 0; }
     if ($("#" + id).val() == '' || $("#" + id).val() == '0000-00-00' || force) {
         $("#" + id).val("<!-- TMPL_VAR NAME="today_iso" -->");
     }
index 161a041..d5f98c4 100644 (file)
@@ -157,7 +157,7 @@ function add_macles(myvalue)
     //for (i=0;i< (mycountMACLESgen - mycountMACLESinit);i++){
     //  PluginAddField(myvalue);
     //}
-      alert("veuillez d'abord creer le nombre de champs necessaires ");
+      alert(_("veuillez d'abord creer le nombre de champs necessaires "));
     } else {
     // Pour chaque valeur cochee, ajouter la valeur dans un noeud MACLES.
       for (i=0;i<tab.length;i++){
index 7ca0d02..cdb3962 100644 (file)
@@ -10,7 +10,7 @@
         }
         function verifyBarcodes(barcodes) {
             if (barcodes.value == '') {
-                alert("Please add barcodes using either the direct entry text area or the item search.");
+                alert(_("Please add barcodes using either the direct entry text area or the item search."));
                 return false;   // not ok
             }
             else {
index 31fcf16..0839814 100644 (file)
@@ -38,7 +38,7 @@
                         }
                     }
                     if (batches.length < 1) {
-                        alert("Please select at least one batch to export.");
+                        alert(_("Please select at least one batch to export."));
                         return;     // no batch selected
                     }
                     getstr = batches.join("&");
@@ -47,7 +47,7 @@
                     getstr = "batch_id="+document.layouts.action.value;
                 }
                 else {
-                    alert("Please select at least one batch to export.");
+                    alert(_("Please select at least one batch to export."));
                     return;     // no batch selected
                 }
                 return GB_showCenter('Export Labels', "/cgi-bin/koha/labels/label-print.pl?" + getstr, 700, 800);
@@ -64,7 +64,7 @@
                         return(document.layouts.action[selected[0]].value);
                     }
                     else {
-                        alert("Please select only one <!-- TMPL_VAR NAME="label_element" --> to " + op + ".");
+                        alert(_('Please select only one ')+'<!-- TMPL_VAR NAME="label_element" -->'+_(' to')+op+'.');
                         return (-1);
                     }
                 }
@@ -73,7 +73,7 @@
                         return(document.layouts.action.value);
                     }
                 };
-                alert("Please select a <!-- TMPL_VAR NAME="label_element" -->.");
+                alert(_('Please select a ')+'<!-- TMPL_VAR NAME="label_element" -->.');
                 return (-1);
             };
         //]]>
index 960052c..260754c 100644 (file)
@@ -10,7 +10,7 @@ $(document).ready(function(){
 });
 function CheckUpload(f){
        if(f.fileToUpload.value == ""){
-               alert("Please choose a file to upload");
+               alert(_("Please choose a file to upload"));
        } else {
                return ajaxFileUpload()
        }
@@ -84,4 +84,4 @@ function CheckForm(f) {
 
 
 </div>
-<!-- TMPL_INCLUDE NAME="intranet-bottom.inc" -->
\ No newline at end of file
+<!-- TMPL_INCLUDE NAME="intranet-bottom.inc" -->
index 0872d17..ecf3511 100644 (file)
@@ -32,7 +32,7 @@
                 else if (document.delete_images.action.checked){
                         return {images:"batch_id="+document.delete_images.action.value, image_ids:document.delete_images.action.value};
                 };
-                alert("Please select image(s) to " + op + ".");
+                alert(_("Please select image(s) to ") + op + ".");
                 return (-1);
             };
             function showHideLayers(element, time, action) {
index 08ab466..a35eabd 100644 (file)
@@ -38,7 +38,7 @@
                         }
                     }
                     if (batches.length < 1) {
-                        alert("Please select at least one batch to export.");
+                        alert(_('Please select at least one batch to export.'));
                         return;     // no batch selected
                     }
                     getstr = batches.join("&");
@@ -47,7 +47,7 @@
                     getstr = "batch_id="+document.layouts.action.value;
                 }
                 else {
-                    alert("Please select at least one batch to export.");
+                    alert(_('Please select at least one batch to export.'));
                     return;     // no batch selected
                 }
                 return GB_showCenter('Export Patron Cards', "/cgi-bin/koha/patroncards/print.pl?" + getstr, 700, 800);
@@ -64,7 +64,7 @@
                         return(document.layouts.action[selected[0]].value);
                     }
                     else {
-                        alert("Please select only one <!-- TMPL_VAR NAME="card_element" --> to " + op + ".");
+                        alert(_('Please select only one ')+'<!-- TMPL_VAR NAME="card_element" -->'+_(' to ') + op + '.');
                         return (-1);
                     }
                 }
@@ -73,7 +73,7 @@
                         return(document.layouts.action.value);
                     }
                 };
-                alert("Please select a <!-- TMPL_VAR NAME="card_element" -->.");
+                alert(_('Please select a ')+'<!-- TMPL_VAR NAME="card_element" -->.');
                 return (-1);
             };
         //]]>
index a2f78ab..c839562 100644 (file)
@@ -13,7 +13,7 @@
             return true;
         }
         else {
-            alert("You must enter a date !");
+            alert(_("You must enter a date !"));
             document.f.date.focus();
             return false;
         }
index b8d7b00..0098596 100644 (file)
@@ -306,7 +306,7 @@ function barcode_check(){
                <h3>Note: Subscription is about to expire next issue.</h3>
                <script type="text/javascript">
                <!--
-               alert("Subscription is about to expire next issue");
+               alert(_("Subscription is about to expire next issue"));
                //-->
                </script>
        <!-- /TMPL_IF -->       
index 331ec2c..d9847dd 100644 (file)
           function checkForm(form) {
               if((form.checkbox[0].checked)){
                   if(!(form.date1.value)){
-                    alert("please enter a date !");
+                    alert(_("please enter a date !"));
                     document.form.date1.focus();
                     return false;
                   }
               }
               if((form.checkbox[1].checked)){
                   if(!(form.date2.value)){
-                      alert("please enter a date !");
+                      alert(_("please enter a date !"));
                       document.form.date2.focus();
                       return false;
                   }
index bac63f6..4397ef0 100644 (file)
@@ -8,7 +8,7 @@
         $(document).ready(function() {
                var inject_old = function(comment) {
                        <!-- TMPL_IF NAME="reviewid" -->
-                       <!-- TMPL_IF NAME="cgi_debug" -->alert("injecting OLD comment: " +comment);<!-- /TMPL_IF -->
+                       <!-- TMPL_IF NAME="cgi_debug" -->alert(_('injecting OLD comment: ')+comment);<!-- /TMPL_IF -->
                        parent.opener.$('#c<!-- TMPL_VAR NAME="reviewid" --> p').prev("small").prev("h5").html("Your Edited Comment (preview, pending approval)");
                        parent.opener.$('#c<!-- TMPL_VAR NAME="reviewid" --> p').html(comment);
                        parent.opener.$('#c<!-- TMPL_VAR NAME="reviewid" --> p').append(" <a href=\"#comment\" onclick=\"Dopop(\'/cgi-bin/koha/opac-review.pl?biblionumber=<!-- TMPL_VAR NAME="biblionumber"-->&amp;reviewid=<!-- TMPL_VAR NAME="reviewid" -->\');\">Edit<\/a>");
@@ -16,7 +16,7 @@
                        return 1;
                };
                var inject_new = function(comment) {
-                       <!-- TMPL_IF NAME="cgi_debug" -->alert("injecting NEW comment: " +comment);<!-- /TMPL_IF -->
+                       <!-- TMPL_IF NAME="cgi_debug" -->alert(_("injecting NEW comment: ") +comment);<!-- /TMPL_IF -->
                        parent.opener.$('#newcomment').attr("class","yours");
                        parent.opener.$('#newcomment').html(
                                "<h5>Your Comment (preview, pending approval)<\/h5>" +