Bug 13898: Remove CANDELETEUSER code
authorJonathan Druart <jonathan.druart@biblibre.com>
Tue, 24 Mar 2015 09:55:50 +0000 (10:55 +0100)
committerTomas Cohen Arazi <tomascohen@gmail.com>
Tue, 31 Mar 2015 14:45:11 +0000 (11:45 -0300)
This code is never used. The permission to delete a patron is now done
in members-toolbar.inc using CAN_user_borrowers.
It's the good way to do.

Test plan:
  git grep CANDELETEUSER
should not return any result

Followed test plan. No CANDELETEUSER found.
Signed-off-by: Marc VĂ©ron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
members/moremember.pl

index 92fe2d9..7dc7ef3 100755 (executable)
@@ -277,23 +277,6 @@ foreach (@$alerts) {
     $_->{relatedto} = findrelatedto( $_->{type}, $_->{externalid} );
 }
 
-my $candeleteuser;
-my $userenv = C4::Context->userenv;
-if ( C4::Context->IsSuperLibrarian() ) {
-    $candeleteuser = 1;
-}
-elsif ( C4::Context->preference("IndependentBranches") ) {
-    $candeleteuser = ( $data->{'branchcode'} eq $userenv->{branch} );
-}
-else {
-    if ( C4::Auth::getuserflags( $userenv->{flags}, $userenv->{number} )->{borrowers} ) {
-        $candeleteuser = 1;
-    }
-    else {
-        $candeleteuser = 0;
-    }
-}
-
 # Add sync data to the user data
 if ( C4::Context->preference('NorwegianPatronDBEnable') && C4::Context->preference('NorwegianPatronDBEnable') == 1 ) {
     my $sync = NLGetSyncDataFromBorrowernumber( $borrowernumber );
@@ -360,7 +343,6 @@ $template->param( $data->{'categorycode'} => 1 );
 $template->param(
     detailview => 1,
     AllowRenewalLimitOverride => C4::Context->preference("AllowRenewalLimitOverride"),
-    CANDELETEUSER    => $candeleteuser,
     roadtype        => $roadtype,
     borrowernumber  => $borrowernumber,
     othernames      => $data->{'othernames'},