Error log is showing warnings because mode is undefined
and we are doing string comparisons on it.
Set it to a default value (we were already assigning it a variable
which we were not using) and use the the result in the comparison
To test, after applying the patch:
[1] Use the renew link from the subscription detail page to renew
a subscription.
[2] Verifying that doing this did not add a warning containing
'subscription-renew.pl: Use of uninitialized value $mode in string eq '
to the Apache error log.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
my $query = new CGI;
my $dbh = C4::Context->dbh;
-my $mode = $query->param('mode');
+my $mode = $query->param('mode') || q{};
my $op = $query->param('op') || q{};
my $subscriptionid = $query->param('subscriptionid');
my $done = 0; # for after form has been submitted
subscriptionid => $subscriptionid,
bibliotitle => $subscription->{bibliotitle},
$op => 1,
- popup => ($query->param('mode')eq "popup"),
+ popup => ($mode eq 'popup'),
);
# Print the page