Bug 6679 - [SIGNED-OFF] fix 4 perlcritic violations in C4/ShelfBrowser.pm

- Variable declared in conditional statement at line 183, column 5.  Declare  variables outside of the condition.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>

diff --git a/C4/ShelfBrowser.pm b/C4/ShelfBrowser.pm
index 449190f..c885d90 100644 (file)
--- a/C4/ShelfBrowser.pm
+++ b/C4/ShelfBrowser.pm
@@ -180,11 +180,16 @@ sub GetNearbyItems {
     my @prev_items = reverse GetShelfInfo($sth_prev_items, $marcflavour);
     my @next_items = GetShelfInfo($sth_next_items, $marcflavour);
 
-    my $next_itemnumber = $next_items[-1]->{itemnumber} if @next_items;
-    my $next_biblionumber = $next_items[-1]->{biblionumber} if @next_items;
+    my (
+        $next_itemnumber, $next_biblionumber,
+        $prev_itemnumber, $prev_biblionumber
+    );
+
+    $next_itemnumber = $next_items[-1]->{itemnumber} if @next_items;
+    $next_biblionumber = $next_items[-1]->{biblionumber} if @next_items;
 
-    my $prev_itemnumber = $prev_items[0]->{itemnumber} if @prev_items;
-    my $prev_biblionumber = $prev_items[0]->{biblionumber} if @prev_items;
+    $prev_itemnumber = $prev_items[0]->{itemnumber} if @prev_items;
+    $prev_biblionumber = $prev_items[0]->{biblionumber} if @prev_items;
 
     my %result = (
         next                => \@next_items,