Bug 16320: [QA Follow-up] Remove warnings from ILSDI/Services.pm

Removes:
Use of uninitialized value in string eq at /home/koha/kohaclone/C4/ILSDI/Services.pm line 373.
Use of uninitialized value in string eq at /home/koha/kohaclone/C4/ILSDI/Services.pm line 390.
Use of uninitialized value in string eq at /home/koha/kohaclone/C4/ILSDI/Services.pm line 399.
Use of uninitialized value in string eq at /home/koha/kohaclone/C4/ILSDI/Services.pm line 423.

Test plan:
Run t/db_dependent/ILSDI_Services.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

diff --git a/C4/ILSDI/Services.pm b/C4/ILSDI/Services.pm
index b1db742..9f5a766 100644 (file)
--- a/C4/ILSDI/Services.pm
+++ b/C4/ILSDI/Services.pm
@@ -370,7 +370,7 @@ sub GetPatronInfo {
     delete $borrower->{'password'};
 
     # Contact fields management
-    if ( $cgi->param('show_contact') eq "0" ) {
+    if ( defined $cgi->param('show_contact') && $cgi->param('show_contact') eq "0" ) {
 
         # Define contact fields
         my @contactfields = (
@@ -387,7 +387,7 @@ sub GetPatronInfo {
     }
 
     # Fines management
-    if ( $cgi->param('show_fines') eq "1" ) {
+    if ( $cgi->param('show_fines') && $cgi->param('show_fines') eq "1" ) {
         my @charges;
         for ( my $i = 1 ; my @charge = getcharges( $borrowernumber, undef, $i ) ; $i++ ) {
             push( @charges, @charge );
@@ -396,7 +396,7 @@ sub GetPatronInfo {
     }
 
     # Reserves management
-    if ( $cgi->param('show_holds') eq "1" ) {
+    if ( $cgi->param('show_holds') && $cgi->param('show_holds') eq "1" ) {
 
         # Get borrower's reserves
         my @reserves = GetReservesFromBorrowernumber( $borrowernumber, undef );
@@ -420,7 +420,7 @@ sub GetPatronInfo {
     }
 
     # Issues management
-    if ( $cgi->param('show_loans') eq "1" ) {
+    if ( $cgi->param('show_loans') && $cgi->param('show_loans') eq "1" ) {
         my $issues = GetPendingIssues($borrowernumber);
         foreach my $issue ( @$issues ){
             $issue->{'issuedate'} = $issue->{'issuedate'}->strftime('%Y-%m-%d %H:%M');