Bug 26018: Fix frameworks errors with subfields in wrong tab
authorKatrin Fischer <katrin.fischer.83@web.de>
Sat, 18 Jul 2020 12:52:06 +0000 (14:52 +0200)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 14 Oct 2020 09:47:57 +0000 (11:47 +0200)
All subfields for a MARC21 field should always be in the same tab.
There were some mistakes found by the "MARC bibliographic framework
test" this fixes.

Before you apply the patch:
- Check the "MARC bibliographic framework test" page
- Ideally you should see the "wrong tab" mistakes
- Reset your db (reset_all) or drop your db and run the web installer
- Verify the page no longer points out any issues

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml

index d299216..a7b2f89 100644 (file)
@@ -12985,7 +12985,7 @@ tables:
           repeatable: 0
           mandatory: 0
           kohafield: ""
-          tab: 1
+          tab: 2
           authorised_value: ""
           authtypecode: ""
           value_builder: ""
@@ -39571,7 +39571,7 @@ tables:
           repeatable: 0
           mandatory: 0
           kohafield: ""
-          tab: 1
+          tab: 7
           authorised_value: ""
           authtypecode: ""
           value_builder: ""
@@ -40435,7 +40435,7 @@ tables:
           repeatable: 0
           mandatory: 0
           kohafield: ""
-          tab: 1
+          tab: 7
           authorised_value: ""
           authtypecode: ""
           value_builder: ""
@@ -40957,7 +40957,7 @@ tables:
           repeatable: 0
           mandatory: 0
           kohafield: ""
-          tab: 1
+          tab: 7
           authorised_value: ""
           authtypecode: ""
           value_builder: ""
@@ -41821,7 +41821,7 @@ tables:
           repeatable: 0
           mandatory: 0
           kohafield: ""
-          tab: 1
+          tab: 7
           authorised_value: ""
           authtypecode: ""
           value_builder: ""
@@ -43297,7 +43297,7 @@ tables:
           repeatable: 0
           mandatory: 0
           kohafield: ""
-          tab: 1
+          tab: 7
           authorised_value: ""
           authtypecode: ""
           value_builder: ""
@@ -52333,7 +52333,7 @@ tables:
           repeatable: 0
           mandatory: 0
           kohafield: ""
-          tab: 1
+          tab: 8
           authorised_value: ""
           authtypecode: ""
           value_builder: ""
@@ -52927,7 +52927,7 @@ tables:
           repeatable: 0
           mandatory: 0
           kohafield: ""
-          tab: 1
+          tab: 8
           authorised_value: ""
           authtypecode: ""
           value_builder: ""
@@ -53485,7 +53485,7 @@ tables:
           repeatable: 0
           mandatory: 0
           kohafield: ""
-          tab: 1
+          tab: 8
           authorised_value: ""
           authtypecode: ""
           value_builder: ""
@@ -54025,7 +54025,7 @@ tables:
           repeatable: 0
           mandatory: 0
           kohafield: ""
-          tab: 1
+          tab: 8
           authorised_value: ""
           authtypecode: ""
           value_builder: ""