Bug 30588: (QA follow-up) Remove erroneous FIXME
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Fri, 9 Sep 2022 09:09:48 +0000 (09:09 +0000)
committerTomas Cohen Arazi <tomascohen@theke.io>
Fri, 21 Oct 2022 14:36:59 +0000 (11:36 -0300)
Comment speaks for itself. Look at surrounding code.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
t/db_dependent/api/v1/two_factor_auth.t

index 63075a6..3a890c3 100755 (executable)
@@ -176,8 +176,7 @@ subtest 'send_otp_token' => sub {
     $tx->req->cookies( { name => 'CGISESSID', value => $session->id } );
     $tx->req->env( { REMOTE_ADDR => $remote_address } );
 
-    # FIXME This is not correct They are authenticated!
-    # Patron is not authenticated yet
+    # Session is still anonymous, no borrowernumber yet: Unauthorized
     $t->request_ok($tx)->status_is(401);
 
     # Patron is partially authenticated (credentials correct)