Bug 6536: QA Follow-up for removing warnings from QA tools

Resolved:
[1]  FAIL   C4/Breeding.pm
FAIL   critic ControlStructures::ProhibitMutatingListFunctions

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
No warnings anymore.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>

diff --git a/C4/Breeding.pm b/C4/Breeding.pm
index 293b933..fa3af82 100644 (file)
--- a/C4/Breeding.pm
+++ b/C4/Breeding.pm
@@ -363,7 +363,7 @@ sub _create_connection {
             #first remove surrounding spaces at comma and equals-sign
             s/^\s+|\s+$//g;
             my @temp= split '=', $_, 2;
-            @temp= map { s/^\s+|\s+$//g; $_; } @temp;
+            @temp= map { my $c=$_; $c=~s/^\s+|\s+$//g; $c; } @temp;
             $option1->option( $temp[0] => $temp[1] ) if @temp;
         }
     } elsif( $server->{servertype} eq 'zed' ) {