Added some FIXME comments.

diff --git a/C4/Biblio.pm b/C4/Biblio.pm
index bb1f1f9..7003e24 100644 (file)
--- a/C4/Biblio.pm
+++ b/C4/Biblio.pm
@@ -1,6 +1,9 @@
 package C4::Biblio;
 # $Id$
 # $Log$
+# Revision 1.23  2002/10/16 12:43:08  arensb
+# Added some FIXME comments.
+#
 # Revision 1.22  2002/10/15 13:39:17  tipaul
 # removing Acquisition.pm
 # deleting unused code in biblio.pm, rewriting POD and answering most FIXME comments
@@ -1606,7 +1609,9 @@ fields from the biblio, biblioitems, aqorders, and aqorderbreakdown
 tables of the Koha database.
 
 =cut
-
+#'
+# FIXME - This is effectively identical to &C4::Catalogue::getorder.
+# Pick one and stick with it.
 sub getorder{
   my ($bi,$bib)=@_;
   my $dbh = C4::Context->dbh;
@@ -1615,6 +1620,8 @@ sub getorder{
        where biblionumber=? and biblioitemnumber=?";
   my $sth=$dbh->prepare($query);
   $sth->execute($bib,$bi);
+  # FIXME - Use fetchrow_array(), since we're only interested in the one
+  # value.
   my $ordnum=$sth->fetchrow_hashref;
   $sth->finish;
   my $order=getsingleorder($ordnum->{'ordernumber'});
@@ -1633,7 +1640,10 @@ C<$order> are fields from the biblio, biblioitems, aqorders, and
 aqorderbreakdown tables of the Koha database.
 
 =cut
-
+#'
+# FIXME - This is effectively identical to
+# &C4::Catalogue::getsingleorder.
+# Pick one and stick with it.
 sub getsingleorder {
   my ($ordnum)=@_;
   my $dbh = C4::Context->dbh;

diff --git a/acqui.simple/bulkmarcimport.pl b/acqui.simple/bulkmarcimport.pl
index 27966da..856b285 100755 (executable)
--- a/acqui.simple/bulkmarcimport.pl
+++ b/acqui.simple/bulkmarcimport.pl
@@ -453,7 +453,9 @@ RECORD:
            my $q_dewey=$dbh->quote($dewey);
            $cleanauthor=$author;
            $cleanauthor=~s/[^A-Za-z]//g;
-           $subclass=uc(substr($cleanauthor,0,3));
+           $subclass=ucz(substr($cleanauthor,0,3));
+                       # FIXME - WTF is the author being converted
+                       # to upper case?
            my $q_subclass=$dbh->quote($subclass);
            my $q_publicationyear=$dbh->quote($publicationyear);
            my $q_publishercode=$dbh->quote($publishercode);    # FIXME - $publishercode undefined
@@ -473,6 +475,8 @@ RECORD:
            foreach $subjectheading (@subjects) {
                # convert to upper case
                $subjectheading=uc($subjectheading);
+                               # FIXME - WTF is the subject being
+                               # converted to upper case?
                # quote value
                my $q_subjectheading=$dbh->quote($subjectheading);
                $sth=$dbh->prepare("insert into bibliosubject (biblionumber,subject)
@@ -487,6 +491,8 @@ RECORD:
                $additionalauthor=~s/\010//g;
                # convert to upper case
                $additionalauthor=uc($additionalauthor);
+                               # FIXME - WTF is the author being converted
+                               # to upper case?
                # quote value
                my $q_additionalauthor=$dbh->quote($additionalauthor);
                $sth=$dbh->prepare("insert into additionalauthors (biblionumber,author) values ($biblionumber, $q_additionalauthor)");

diff --git a/koha-tmpl/intranet-tmpl/default/en/catalogue/detail-opac.tmpl b/koha-tmpl/intranet-tmpl/default/en/catalogue/detail-opac.tmpl
index ae5e065..f47ca05 100644 (file)
--- a/koha-tmpl/intranet-tmpl/default/en/catalogue/detail-opac.tmpl
+++ b/koha-tmpl/intranet-tmpl/default/en/catalogue/detail-opac.tmpl
@@ -10,6 +10,7 @@
 <TMPL_LOOP NAME="BIBLIO_RESULTS">
 <font SIZE=6><em><TMPL_VAR NAME="title"> (<TMPL_VAR NAME="author">)
 <TMPL_VAR NAME="class"></em></font><p>
+<!-- FIXME - "callpadding" should be "cellpadding", right? -->
 <table cellspacing="0" callpadding="5" border="1" align="left" width="220">
 <!-----------------BIBLIO RECORD TABLE--------->
 <tr valign="top">

diff --git a/koha-tmpl/intranet-tmpl/default/en/catalogue/detail.tmpl b/koha-tmpl/intranet-tmpl/default/en/catalogue/detail.tmpl
index 63d6409..19091e4 100644 (file)
--- a/koha-tmpl/intranet-tmpl/default/en/catalogue/detail.tmpl
+++ b/koha-tmpl/intranet-tmpl/default/en/catalogue/detail.tmpl
@@ -20,6 +20,7 @@ src="/images/requests.gif" align="right" border="0"></a>
 
 <font SIZE=6><em><TMPL_VAR NAME="title"> (<TMPL_VAR NAME="author">)
 <TMPL_VAR NAME="class"></em></font><p>
+<!-- FIXME - "callpadding" should be "cellpadding", right? -->
 <table cellspacing="0" callpadding="5" border="1" align="left" width="220">
 <!-----------------BIBLIO RECORD TABLE--------->
 <tr valign="top">
@@ -60,6 +61,14 @@ NAME="author" ESCAPE=URL>><TMPL_VAR NAME="author"></a><br>
 </tr>
 </table>
 </TMPL_LOOP>
+<!-- FIXME - The help box overflows on the right. I think this is
+     because it is specified as "width=70%", which the browser
+     interprets as 70% of the width of the browser window. However,
+     leaving out the "width=70%" makes the help box abut the "biblio
+     record" box. I think the fix is to put all three boxes in a
+     table, for layout, and make the help box as wide as it wants to
+     be. -->
+
 <center>
 <table border=0 cellspacing=0 cellpadding=2>
 <tr bgcolor="#cccc99" background="/images/background-mem.gif">

diff --git a/koha-tmpl/intranet-tmpl/default/en/marcimport/marcimportdetail.tmpl b/koha-tmpl/intranet-tmpl/default/en/marcimport/marcimportdetail.tmpl
index 22ba4e6..f814766 100644 (file)
--- a/koha-tmpl/intranet-tmpl/default/en/marcimport/marcimportdetail.tmpl
+++ b/koha-tmpl/intranet-tmpl/default/en/marcimport/marcimportdetail.tmpl
@@ -3,6 +3,7 @@
 <img height=42  WIDTH=120 BORDER="0" src="/images/requests.gif" align="right" border="0"></a>
 <font SIZE=6><em><TMPL_VAR NAME="title"> (<TMPL_VAR NAME="author">)
 <TMPL_VAR NAME="class"></em></font><p>
+<!-- FIXME - "callpadding" should be "cellpadding", right? -->
 <table cellspacing="0" callpadding="5" border="1" align="left" width="220">
 <!-----------------old style RECORD TABLE--------->
 <center>

diff --git a/koha-tmpl/opac-tmpl/default/en/opac-detail.tmpl b/koha-tmpl/opac-tmpl/default/en/opac-detail.tmpl
index 35397c8..4daf839 100644 (file)
--- a/koha-tmpl/opac-tmpl/default/en/opac-detail.tmpl
+++ b/koha-tmpl/opac-tmpl/default/en/opac-detail.tmpl
@@ -15,6 +15,7 @@
 <TMPL_LOOP NAME="BIBLIO_RESULTS">
 <font SIZE=6><em><TMPL_VAR NAME="title"> (<TMPL_VAR NAME="author">)
 <TMPL_VAR NAME="class"></em></font><p>
+<!-- FIXME - "callpadding" should be "cellpadding", right? -->
 <table cellspacing="0" callpadding="5" border="1" align="left" width="220">
 <!-----------------BIBLIO RECORD TABLE--------->
 <tr valign="top">

diff --git a/koha-tmpl/opac-tmpl/default/en/opac-moredetail.tmpl b/koha-tmpl/opac-tmpl/default/en/opac-moredetail.tmpl
index 3b9445d..50ae2bf 100644 (file)
--- a/koha-tmpl/opac-tmpl/default/en/opac-moredetail.tmpl
+++ b/koha-tmpl/opac-tmpl/default/en/opac-moredetail.tmpl
@@ -70,7 +70,7 @@ BORDER=0 src="/images/delete-mem.gif">
 <b>Home Branch:</b> <TMPL_VAR NAME="homebranch"><br>
 <b>Last seen:</b> <TMPL_VAR NAME="datelastseen"><br>
 <b>Last borrowed:</b> <TMPL_VAR NAME="timestamp0"><br>
-on issue bit
+on issue bit <!-- FIXME - What's this, then? -->
 <b>Last Borrower 1:</b> <TMPL_VAR NAME="card0"><br>
 <b>Last Borrower 2:</b> <TMPL_VAR NAME="card1"><br>
 <b>Current Branch:</b> <TMPL_VAR NAME="holdingbranch"><br>

diff --git a/search.pl b/search.pl
index 5d1a994..3a41869 100755 (executable)
--- a/search.pl
+++ b/search.pl
@@ -28,12 +28,12 @@ use C4::Output;
 
 my $query=new CGI;
 my $type=$query->param('type');
-warn $type;
+warn $type;            # FIXME - What's this for?
 
 #(-e "opac") && ($type='opac');
 
 my ($loggedinuser, $cookie, $sessionID) = checkauth($query, ($type eq 'opac') ? (1) : (0));
-warn $type;
+warn $type;            # FIXME - What's this for?
 
 my $startfrom=$query->param('startfrom');
 ($startfrom) || ($startfrom=0);