Bug 16224: Fix t/db_dependent/Reports_Guided.t
authorJulian Maurice <julian.maurice@biblibre.com>
Thu, 7 Apr 2016 15:03:47 +0000 (17:03 +0200)
committerBrendan Gallagher <bredan@bywatersolutions.com>
Wed, 20 Apr 2016 19:48:44 +0000 (19:48 +0000)
This test:

is( scalar @{ get_saved_reports( $report_ids[0] ) }, 1,
"filter takes report id" );

can fail when $report_ids[0] is a substring of some saved_sql fields
from other reports (reports that have a different id than
$report_ids[0]).
We can only be sure that get_saved_reports will return at least 1
report.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan Gallagher <bredan@bywatersolutions.com>
t/db_dependent/Reports_Guided.t

index 4d89ebd..163a67d 100755 (executable)
@@ -70,8 +70,7 @@ like( $report_ids[2], '/^\d+$/', "Save_report returns an id for third" );
 is( scalar @{ get_saved_reports() },
     $count, "$count reports have been added" );
 
-is( scalar @{ get_saved_reports( $report_ids[0] ) },
-    1, "filter takes report id" );
+ok( 0 < scalar @{ get_saved_reports( $report_ids[0] ) }, "filter takes report id" );
 
 #Test delete_report
 is (delete_report(),undef, "Without id delete_report returns undef");