Bug 28946: (bug 23271 follow-up) Missing occurrence in add_user_search.pl
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 10 Sep 2021 08:03:05 +0000 (10:03 +0200)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 14 Sep 2021 16:23:28 +0000 (18:23 +0200)
commit f6e0b04f48e8f0a02dbb8d48152646257d9accba
Bug 23271: Replace search_limited with search_with_library_limits

We were modifying the occurrences of:
  Koha::Patron::Categories->search_limited;
with:
  Koha::Patron::Categories->search_with_library_limits;

But between the patch submission and the push, another occurrence has
been added by bug 23590.

Test plan:
Create a new suggestion from staff and click "select manager"
Without the patch, notice the error:
  The method Koha::Patron::Categories->search_limited is not covered by tests!
With the patch applied everything is working correctly

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
suggestion/add_user_search.pl

index d4b5ff0..d71d033 100755 (executable)
@@ -49,7 +49,7 @@ my $search_patrons_with_suggestion_perm_only =
     ( $permissions && $permissions eq 'suggestions.suggestions_manage' )
         ? 1 : 0;
 
-my $patron_categories = Koha::Patron::Categories->search_limited;
+my $patron_categories = Koha::Patron::Categories->search_with_library_limits({}, {order_by => ['description']});;
 $template->param(
     patrons_with_suggestion_perm_only => $search_patrons_with_suggestion_perm_only,
     view => ( $input->request_method() eq "GET" ) ? "show_form" : "show_results",