Bug 32878: (follow-up) Exclude non_priority holds

This patch filters out non_priorty holds in the on_reserve condition.

Test plan
1) Run t/db_dependant/Holds.t
2) Note it fails without this patch
3) Apply patch
4) Re-run the above test, note it now passes

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

diff --git a/C4/Circulation.pm b/C4/Circulation.pm
index 6677b82..e190019 100644 (file)
--- a/C4/Circulation.pm
+++ b/C4/Circulation.pm
@@ -2957,7 +2957,7 @@ sub CanBookBeRenewed {
 
     # There is an item level hold on this item, no other item can fill the hold
     return ( 0, "on_reserve" )
-        if ( $item->current_holds->count );
+      if ( $item->current_holds->search( { non_priority => 0 } )->count );
 
     my $fillable_holds = Koha::Holds->search(
         {