Bug 19540: Tell the patron why a hold cannot be placed on items

This patch adds an explanation when a hold cannot be placed, in some situation:
tooManyReserves
tooManyHoldsForThisRecord
tooManyReservesToday
itemAlreadyOnHold

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
index 1d1d55f..176ee43 100644 (file)
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
@@ -203,8 +203,16 @@
                                     [% ELSIF ( bibitemloo.recall ) %]
                                         <div class="alert alert-warning">You have already placed a recall on this title.</div>
                                     [% ELSE %]
-                                        [% IF ( bibitemloo.already_patron_possession ) %]
+                                        [% IF bibitemloo.alreadypossession %]
                                             <div class="alert alert-warning">This title cannot be requested because it's already in your possession.</div>
+                                        [% ELSIF bibitemloo.tooManyReserves %]
+                                            <div class="alert alert-warning">This title cannot be requested because you reached the maximum number of holds.</div>
+                                        [% ELSIF bibitemloo.tooManyHoldsForThisRecord %]
+                                            <div class="alert alert-warning">This title cannot be requested because you exceeded max holds per record.</div>
+                                        [% ELSIF bibitemloo.tooManyReservesToday %]
+                                            <div class="alert alert-warning">This title cannot be requested because you reached the daily hold limit.</div>
+                                        [% ELSIF bibitemloo.itemAlreadyOnHold %]
+                                            <div class="alert alert-warning">This title cannot be requested because you already have hold for this item.</div>
                                         [% ELSE %]
                                             [% UNLESS ( bibitemloo.bib_available ) %]
                                                 <div class="alert">There are no items that can be placed on hold.</div>

diff --git a/opac/opac-reserve.pl b/opac/opac-reserve.pl
index 20f67e8..e32a41e 100755 (executable)
--- a/opac/opac-reserve.pl
+++ b/opac/opac-reserve.pl
@@ -565,7 +565,7 @@ foreach my $biblioNum (@biblionumbers) {
 
     my $status = CanBookBeReserved( $borrowernumber, $biblioNum )->{status};
     $biblioLoopIter{holdable} &&= $status eq 'OK';
-    $biblioLoopIter{already_patron_possession} = $status eq 'alreadypossession';
+    $biblioLoopIter{$status} = 1;
 
     if ( $biblioLoopIter{holdable} and C4::Context->preference('AllowHoldItemTypeSelection') ) {
         # build the allowed item types loop