Bug 26311: (QA follow-up) Rephrase output message
authorKatrin Fischer <katrin.fischer.83@web.de>
Mon, 14 Sep 2020 07:07:01 +0000 (07:07 +0000)
committerTomas Cohen Arazi <tomascohen@theke.io>
Tue, 5 Jul 2022 12:20:50 +0000 (09:20 -0300)
This is a suggestion for rephrasing the message slightly:

Before:
* Patron borrowernumber=15 in category 'J' has invalid age '56'

After:
* Patron borrowernumber=37 has an invalid age of 37 for their category 'K'

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
misc/maintenance/search_for_data_inconsistencies.pl

index e64758d..00f5832 100755 (executable)
@@ -286,10 +286,10 @@ use C4::Biblio qw( GetMarcFromKohaField );
     if (@invalid_patrons) {
         new_section("Patrons with invalid age for category");
         foreach my $patron (@invalid_patrons) {
-            new_item( sprintf "Patron borrowernumber=%s in category '%s' has invalid age '%s'",
-                $patron->borrowernumber, $patron->category->categorycode, $patron->get_age );
+            new_item( sprintf "Patron borrowernumber=%s has an invalid age of %s for their category '%s'",
+                $patron->borrowernumber, $patron->get_age, $patron->category->categorycode, );
         }
-        new_hint("You may change patron's category automatically with misc/cronjobs/update_patrons_category.pl");
+        new_hint("You may change the patron's category automatically with misc/cronjobs/update_patrons_category.pl");
     }
 }