Bug 32828: Fix cataloguing/value_builder/unimarc_field_115a.pl
authorJulian Maurice <julian.maurice@biblibre.com>
Fri, 3 Feb 2023 10:58:52 +0000 (11:58 +0100)
committerTomas Cohen Arazi <tomascohen@theke.io>
Fri, 24 Feb 2023 20:01:17 +0000 (17:01 -0300)
Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
cataloguing/value_builder/unimarc_field_115a.pl

index fc0223a..75b74f6 100755 (executable)
@@ -32,7 +32,9 @@ sub plugin_javascript {
     my ( $dbh, $record, $tagslib, $field_number ) = @_;
     my $res = "
     <script>
-    function Clic$field_number(i) {
+    function Clic$field_number(event) {
+        event.preventDefault();
+        const i = event.data.id;
         var defaultvalue;
         try {
             defaultvalue = document.getElementById(i).value;
@@ -40,7 +42,7 @@ sub plugin_javascript {
             alert('error when getting '+i);
             return;
         }
-       window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_115a.pl&index=$field_number&result=\"+defaultvalue,\"unimarc_field_115a\",'width=1200,height=600,toolbar=false,scrollbars=yes');
+        window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_115a.pl&index=\" + i + \"&result=\"+defaultvalue,\"unimarc_field_115a\",'width=1200,height=600,toolbar=false,scrollbars=yes');
     }
 
     </script>