Bug 17904: Fix possible SQL injection in late orders

To recreate:
/cgi-bin/koha/acqui/lateorders.plop=send_alert&ordernumber=1)and%20(select*from(select(sleep(20)))a)--%20&letter_code=0

Notice the delay.

The SQL query is not constructed correctly, placeholders must be used.

This vulnerability has been reported by MDSec.

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

diff --git a/C4/Letters.pm b/C4/Letters.pm
index d62f827..f6802ce 100644 (file)
--- a/C4/Letters.pm
+++ b/C4/Letters.pm
@@ -478,10 +478,10 @@ sub SendAlerts {
                 carp "No order selected";
                 return { error => "no_order_selected" };
             }
                 carp "No order selected";
                 return { error => "no_order_selected" };
             }

-            $strsth .= join( ",", @$externalid ) . ")";
+            $strsth .= join( ",", ('?') x @$externalid ) . ")";

             $action = "ACQUISITION CLAIM";
             $sthorders = $dbh->prepare($strsth);
             $action = "ACQUISITION CLAIM";
             $sthorders = $dbh->prepare($strsth);

-            $sthorders->execute;
+            $sthorders->execute( @$externalid );

             $dataorders = $sthorders->fetchall_arrayref( {} );
         }
 
             $dataorders = $sthorders->fetchall_arrayref( {} );
         }