Due to the logic of the underlying picture-upload.pl depending upon the "value" of the
form input controls and this value being translated, the script then failed to function.
This patch changes the input controls so that this should not be an issue.
This issue should be kept in mind, though, so that it can be avoided in the future.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
</li>
</ol>
<fieldset class="action">
</li>
</ol>
<fieldset class="action">
- <input name="op" type="submit" value="Upload" class="submit" />
- <!-- TMPL_IF NAME="picture" --><input name="op" type="submit" value="Delete" class="submit" /><!-- /TMPL_IF -->
+ <input type="submit" value="Upload" class="submit" />
+ <input name="op" type="hidden" value="Upload" />
+ <!-- TMPL_IF NAME="picture" --><a href="/cgi-bin/koha/tools/picture-upload.pl?op=Delete&cardnumber=<!-- TMPL_VAR NAME="cardnumber" -->&borrowernumber=<!-- TMPL_VAR NAME="borrowernumber" -->" class="delete">Delete</a><!-- /TMPL_IF -->
</fieldset>
</fieldset>
</form>
</fieldset>
</fieldset>
</form>
</li></ol>
</fieldset>
<fieldset class="action">
</li></ol>
</fieldset>
<fieldset class="action">
- <input type="submit" name="op" value="Upload" class="submit" />
- <input type="submit" name="op" value="Cancel" class="submit" />
+ <input type="hidden" name="op" value="Upload" />
+ <input type="submit" value="Upload" class="submit" />
+ <a href="/cgi-bin/koha/tools/tools-home.pl" class="cancel">Cancel</a>
# Other parts of this code could be optimized as well, I think. Perhaps the file upload could be done with YUI's upload
# coded. -fbcit
# Other parts of this code could be optimized as well, I think. Perhaps the file upload could be done with YUI's upload
# coded. -fbcit
-$debug and warn "Params are: filetype=$filetype, cardnumber=$cardnumber, uploadfile=$uploadfilename";
+$debug and warn "Params are: filetype=$filetype, cardnumber=$cardnumber, borrowernumber=$borrowernumber, uploadfile=$uploadfilename";
$template->param(filetype => $filetype);
} elsif ( $op eq 'Delete' ) {
my $dberror = RmPatronImage($cardnumber);
$template->param(filetype => $filetype);
} elsif ( $op eq 'Delete' ) {
my $dberror = RmPatronImage($cardnumber);
+ $debug and warn "Patron image deleted for $cardnumber";
warn "Database returned $dberror" if $dberror;
warn "Database returned $dberror" if $dberror;
-} elsif ( $op eq 'Cancel' ) {
- print $input->redirect ("/cgi-bin/koha/tools/picture-upload.pl");
if ( $borrowernumber && !$errors && !$template->param('ERRORS') ) {
print $input->redirect ("/cgi-bin/koha/members/moremember.pl?borrowernumber=$borrowernumber");
} else {
if ( $borrowernumber && !$errors && !$template->param('ERRORS') ) {
print $input->redirect ("/cgi-bin/koha/members/moremember.pl?borrowernumber=$borrowernumber");
} else {