The column maxsuspensiondays was added in the datatable but not in the tests, which caused the failure of the tests
test plan: execute prove t/db_dependent/Circulation_Issuingrule.t
The command has to print:
t/db_dependent/Circulation_Issuingrule.t .. ok
All tests successful.
Files=1, Tests=9, 2 wallclock secs ( 0.03 usr 0.01 sys + 1.35 cusr 0.08 csys = 1.47 CPU)
Result: PASS
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Failure on test before patch, success after
No koha-qa errors
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
renewalsallowed => 0,
firstremind => 0,
itemtype => 'BOOK',
renewalsallowed => 0,
firstremind => 0,
itemtype => 'BOOK',
- categorycode => $samplecat->{categorycode}
+ categorycode => $samplecat->{categorycode},
+ maxsuspensiondays => 0,
};
my $sampleissuingrule2 = {
branchcode => $samplebranch2->{branchcode},
};
my $sampleissuingrule2 = {
branchcode => $samplebranch2->{branchcode},
accountsent => 'Null',
reservecharge => 'Null',
chargename => 'Null',
accountsent => 'Null',
reservecharge => 'Null',
chargename => 'Null',
- restrictedtype => 'Null'
+ restrictedtype => 'Null',
+ maxsuspensiondays => 0,
};
my $sampleissuingrule3 = {
branchcode => $samplebranch1->{branchcode},
};
my $sampleissuingrule3 = {
branchcode => $samplebranch1->{branchcode},
accountsent => 'Null',
reservecharge => 'Null',
chargename => 'Null',
accountsent => 'Null',
reservecharge => 'Null',
chargename => 'Null',
- restrictedtype => 'Null'
+ restrictedtype => 'Null',
+ maxsuspensiondays => 0,
};
$query = 'INSERT INTO issuingrules (
branchcode,
};
$query = 'INSERT INTO issuingrules (
branchcode,
accountsent,
reservecharge,
chargename,
accountsent,
reservecharge,
chargename,
- restrictedtype
- ) VALUES(?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?)';
+ restrictedtype,
+ maxsuspensiondays
+ ) VALUES(?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?)';
my $sth = $dbh->prepare($query);
$sth->execute(
$sampleissuingrule1->{branchcode},
my $sth = $dbh->prepare($query);
$sth->execute(
$sampleissuingrule1->{branchcode},
$sampleissuingrule1->{accountsent},
$sampleissuingrule1->{reservecharge},
$sampleissuingrule1->{chargename},
$sampleissuingrule1->{accountsent},
$sampleissuingrule1->{reservecharge},
$sampleissuingrule1->{chargename},
- $sampleissuingrule1->{restrictedtype}
+ $sampleissuingrule1->{restrictedtype},
+ $sampleissuingrule1->{maxsuspensiondays},
);
$sth->execute(
$sampleissuingrule2->{branchcode},
);
$sth->execute(
$sampleissuingrule2->{branchcode},
$sampleissuingrule2->{accountsent},
$sampleissuingrule2->{reservecharge},
$sampleissuingrule2->{chargename},
$sampleissuingrule2->{accountsent},
$sampleissuingrule2->{reservecharge},
$sampleissuingrule2->{chargename},
- $sampleissuingrule2->{restrictedtype}
+ $sampleissuingrule2->{restrictedtype},
+ $sampleissuingrule2->{maxsuspensiondays},
);
$sth->execute(
$sampleissuingrule3->{branchcode},
);
$sth->execute(
$sampleissuingrule3->{branchcode},
$sampleissuingrule3->{accountsent},
$sampleissuingrule3->{reservecharge},
$sampleissuingrule3->{chargename},
$sampleissuingrule3->{accountsent},
$sampleissuingrule3->{reservecharge},
$sampleissuingrule3->{chargename},
- $sampleissuingrule3->{restrictedtype}
+ $sampleissuingrule3->{restrictedtype},
+ $sampleissuingrule3->{maxsuspensiondays},