We are adding (or already doing) a Koha::Biblios->find, so we should
get rid of GetBiblioData, fetching the same data.
It returned a few extra columns, but unused here:
$dat->{bnotes}, $dat->{bi_notforloan}
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
use CGI qw ( -utf8 );
use C4::Koha;
use C4::Biblio qw(
use CGI qw ( -utf8 );
use C4::Koha;
use C4::Biblio qw(
GetMarcBiblio
GetMarcSeries
GetMarcSubjects
GetMarcBiblio
GetMarcSeries
GetMarcSubjects
foreach my $biblionumber ( @bibs ) {
$template->param( biblionumber => $biblionumber );
foreach my $biblionumber ( @bibs ) {
$template->param( biblionumber => $biblionumber );
- my $dat = &GetBiblioData($biblionumber);
- next unless $dat;
- my $biblio = Koha::Biblios->find( $biblionumber );
+ my $biblio = Koha::Biblios->find( $biblionumber ) or next;
+ my $dat = $biblio->unblessed;
my $record = &GetMarcBiblio({ biblionumber => $biblionumber });
my $marcnotesarray = $biblio->get_marc_notes({ marcflavour => $marcflavour });
my $marcauthorsarray = $biblio->get_marc_authors;
my $record = &GetMarcBiblio({ biblionumber => $biblionumber });
my $marcnotesarray = $biblio->get_marc_notes({ marcflavour => $marcflavour });
my $marcauthorsarray = $biblio->get_marc_authors;
use Try::Tiny qw( catch try );
use C4::Biblio qw(
use Try::Tiny qw( catch try );
use C4::Biblio qw(
GetMarcBiblio
GetMarcSubjects
);
GetMarcBiblio
GetMarcSubjects
);
foreach my $biblionumber (@bibs) {
$template2->param( biblionumber => $biblionumber );
foreach my $biblionumber (@bibs) {
$template2->param( biblionumber => $biblionumber );
- my $dat = GetBiblioData($biblionumber);
- next unless $dat;
- my $biblio = Koha::Biblios->find( $biblionumber );
+ my $biblio = Koha::Biblios->find( $biblionumber ) or next;
+ my $dat = $biblio->unblessed;
my $record = GetMarcBiblio({
biblionumber => $biblionumber,
embed_items => 1 });
my $record = GetMarcBiblio({
biblionumber => $biblionumber,
embed_items => 1 });
use C4::Koha;
use C4::Biblio qw(
use C4::Koha;
use C4::Biblio qw(
GetFrameworkCode
GetMarcBiblio
GetMarcSeries
GetFrameworkCode
GetMarcBiblio
GetMarcSeries
foreach my $biblionumber ( @bibs ) {
$template->param( biblionumber => $biblionumber );
foreach my $biblionumber ( @bibs ) {
$template->param( biblionumber => $biblionumber );
- my $dat = &GetBiblioData($biblionumber);
- next unless $dat;
- my $biblio = Koha::Biblios->find( $biblionumber );
+ my $biblio = Koha::Biblios->find( $biblionumber ) or next;
+ my $dat = $biblio->unblessed;
# No filtering on the item records needed for the record itself
# since the only reason item information is grabbed is because of branchcodes.
# No filtering on the item records needed for the record itself
# since the only reason item information is grabbed is because of branchcodes.
use Try::Tiny qw( catch try );
use C4::Biblio qw(
use Try::Tiny qw( catch try );
use C4::Biblio qw(
GetMarcBiblio
GetMarcSubjects
);
GetMarcBiblio
GetMarcSubjects
);
foreach my $biblionumber (@bibs) {
$template2->param( biblionumber => $biblionumber );
foreach my $biblionumber (@bibs) {
$template2->param( biblionumber => $biblionumber );
- my $dat = GetBiblioData($biblionumber);
- next unless $dat;
- my $biblio = Koha::Biblios->find( $biblionumber );
+ my $biblio = Koha::Biblios->find( $biblionumber ) or next;
+ my $dat = $biblio->unblessed;
my $record = GetMarcBiblio({
biblionumber => $biblionumber,
embed_items => 1,
my $record = GetMarcBiblio({
biblionumber => $biblionumber,
embed_items => 1,