To test:
1) Activate the IllModule system preference
2) Install a backend (BLDSS or FreeForm) following the wiki instructions:
3) Configure some authorised values for ILLSTATUS
4) Apply patch
5) Run database update
6) Verify your configured values have been updated to ILL_STATUS_ALIAS
7) Add another ILL_STATUS_ALIAS: there should now be an explanation in the
categories list
8) Go to the ILL module and add a new request
9) Edit the request, verify that your status alias show in the status list
10) Set one of your status and save
11) Verify that the ILL requests list search filters show your status alias
12) Manage the request again and verify that the ILL request log shows the
status descriptions correctly
13) Verify the description of the ILLHiddenRequestStatuses has
been updated with the new authorised value category
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
my ( $self ) = @_;
return unless $self->status_alias;
# We can't know which result is the right one if there are multiple
my ( $self ) = @_;
return unless $self->status_alias;
# We can't know which result is the right one if there are multiple
- # ILLSTATUS authorised values with the same authorised_value column value
+ # ILL_STATUS_ALIAS authorised values with the same authorised_value column value
# so we just use the first
return Koha::AuthorisedValues->search(
{
# so we just use the first
return Koha::AuthorisedValues->search(
{
- category => 'ILLSTATUS',
+ category => 'ILL_STATUS_ALIAS',
authorised_value => $self->SUPER::status_alias
},
{},
authorised_value => $self->SUPER::status_alias
},
{},
return $ret;
}
# We can't know which result is the right one if there are multiple
return $ret;
}
# We can't know which result is the right one if there are multiple
- # ILLSTATUS authorised values with the same authorised_value column value
+ # ILL_STATUS_ALIAS authorised values with the same authorised_value column value
# so we just use the first
my $alias = Koha::AuthorisedValues->search(
{
# so we just use the first
my $alias = Koha::AuthorisedValues->search(
{
- category => 'ILLSTATUS',
+ category => 'ILL_STATUS_ALIAS',
authorised_value => $self->SUPER::status_alias
},
{},
authorised_value => $self->SUPER::status_alias
},
{},
$notice_hash->{$notice->{code}} = $notice;
}
# Populate a lookup table for status aliases
$notice_hash->{$notice->{code}} = $notice;
}
# Populate a lookup table for status aliases
- my $aliases = C4::Koha::GetAuthorisedValues('ILLSTATUS');
+ my $aliases = C4::Koha::GetAuthorisedValues('ILL_STATUS_ALIAS');
my $alias_hash;
foreach my $alias(@{$aliases}) {
$alias_hash->{$alias->{authorised_value}} = $alias;
my $alias_hash;
foreach my $alias(@{$aliases}) {
$alias_hash->{$alias->{authorised_value}} = $alias;
--- /dev/null
+use Modern::Perl;
+
+return {
+ bug_number => "32799",
+ description => "Rename ILLSTATUS authorised value category",
+ up => sub {
+ my ($args) = @_;
+ my ($dbh, $out) = @$args{qw(dbh out)};
+ # Do you stuffs here
+ $dbh->do(q{UPDATE authorised_value_categories SET category_name = "ILL_STATUS_ALIAS" WHERE category_name = "ILLSTATUS"});
+ # Print useful stuff here
+ say $out "Renamed authorised value category 'ILLSTATUS' to 'ILL_STATUS_ALIAS'";;
+ },
+};
-- For Interlibrary loans
INSERT IGNORE INTO authorised_value_categories( category_name ) VALUES
-- For Interlibrary loans
INSERT IGNORE INTO authorised_value_categories( category_name ) VALUES
-- For Claims returned
INSERT IGNORE INTO authorised_value_categories( category_name ) VALUES
-- For Claims returned
INSERT IGNORE INTO authorised_value_categories( category_name ) VALUES
<p>General holdings: type of unit designator</p>
[% CASE 'HOLD_CANCELLATION' %]
<p>Reasons why a hold might have been cancelled</p>
<p>General holdings: type of unit designator</p>
[% CASE 'HOLD_CANCELLATION' %]
<p>Reasons why a hold might have been cancelled</p>
+ [% CASE 'ILL_STATUS_ALIAS' %]
+ <p>ILL request status aliases used by the interlibrary loans module</p>
[% CASE 'AR_CANCELLATION' %]
<p>Reasons why an article request might have been cancelled</p>
[% CASE 'HSBND_FREQ' %]
[% CASE 'AR_CANCELLATION' %]
<p>Reasons why an article request might have been cancelled</p>
[% CASE 'HSBND_FREQ' %]
- "ILL statuses that are considered finished and should not be displayed in the ILL module: "
- pref: ILLHiddenRequestStatuses
class: multi
- "ILL statuses that are considered finished and should not be displayed in the ILL module: "
- pref: ILLHiddenRequestStatuses
class: multi
- - (separated with |). If left empty, all ILL requests will be displayed. The request codes can be found in the <a href="/cgi-bin/koha/admin/authorised_values.pl?searchfield=ILLSTATUS">ILLSTATUS</a> authorized value category.
+ - (separated with |). If left empty, all ILL requests will be displayed. The request codes are defined in the backends and additional aliases can be configured via the <a href="/cgi-bin/koha/admin/authorised_values.pl?searchfield=ILL_STATUS_ALIAS">ILL_STATUS_ALIAS</a> authorized value category.
Notifications:
-
- "Send these ILL notices to staff when appropriate:"
Notifications:
-
- "Send these ILL notices to staff when appropriate:"
[% END %]
[% request.capabilities.$stat.name | html %]
</option>
[% END %]
[% request.capabilities.$stat.name | html %]
</option>
- [% FOREACH alias IN AuthorisedValues.Get('ILLSTATUS') %]
+ [% FOREACH alias IN AuthorisedValues.Get('ILL_STATUS_ALIAS') %]
[% IF alias.authorised_value == current_alias %]
<option value="[% alias.authorised_value | html %]" selected>
[% ELSE %]
[% IF alias.authorised_value == current_alias %]
<option value="[% alias.authorised_value | html %]" selected>
[% ELSE %]
my $cat = Koha::AuthorisedValueCategories->search(
{
my $cat = Koha::AuthorisedValueCategories->search(
{
- category_name => 'ILLSTATUS'
+ category_name => 'ILL_STATUS_ALIAS'
{
class => 'Koha::AuthorisedValueCategory',
value => {
{
class => 'Koha::AuthorisedValueCategory',
value => {
- category_name => 'ILLSTATUS'
+ category_name => 'ILL_STATUS_ALIAS'
{
class => 'Koha::AuthorisedValues',
value => {
{
class => 'Koha::AuthorisedValues',
value => {
- category => 'ILLSTATUS'
+ category => 'ILL_STATUS_ALIAS'
- is($av->category, 'ILLSTATUS',
+ is($av->category, 'ILL_STATUS_ALIAS',
"Successfully created authorised value for custom status");
my $ill_req = $builder->build_object(
"Successfully created authorised value for custom status");
my $ill_req = $builder->build_object(