In koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt,
fix line splitted TT directives and sentence splitting leading
to translatability problems. (See first comment).
To test:
- Apply patch
- Go to detail pages of biblios with waiting holds
- Verify that messages in column 'Status' are OK
- Examine code in patch to make sure that the simplification in logic
makes sense and that no TT directive is splitted
- Bonus test:
- Go to folder misc/translator. Run perl translate create xx-XX
- Verify that monster mentioned in first comment no longer exists
(in po/xx-XX-staff-prog.po)
Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised
Amended for wording (comment #5) 2016-07-26 mv
Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
[% IF ( item.reservedate ) %]
[% IF ( item.waitingdate ) %]
[% IF ( item.reservedate ) %]
[% IF ( item.waitingdate ) %]
+ Waiting at [% item.ExpectedAtLibrary %] since [% item.waitingdate | $KohaDates %].
+ Item-level hold (placed [% item.reservedate | $KohaDates %]) for delivery at [% item.ExpectedAtLibrary %].
[% END %]
[% IF ( canreservefromotherbranches ) %]
[% END %]
[% IF ( canreservefromotherbranches ) %]
- for <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% item.ReservedForBorrowernumber %]">
+ Hold for: <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% item.ReservedForBorrowernumber %]">
[% IF ( item.hidepatronname ) %]
[% item.Reservedcardnumber %]
[% ELSE %]
[% IF ( item.hidepatronname ) %]
[% item.Reservedcardnumber %]
[% ELSE %]
- [% item.ReservedForFirstname %] [% item.ReservedForSurname %]
+ [% item.ReservedForFirstname _ item.ReservedForSurname _ " (" _ item.Reservedcardnumber _ ")" %]
- [% IF ( item.waitingdate ) %]
- at[% ELSE %]for delivery at
- [% END %]
- [% item.ExpectedAtLibrary %]
- [% IF ( item.waitingdate ) %]
- since [% item.waitingdate | $KohaDates %]
- [% ELSE %]
- [% IF ( item.reservedate ) %]
- (placed [% item.reservedate | $KohaDates %])
- [% END %]
- [% END %]
- [% UNLESS (
- item.itemnotforloan
- or item.notforloan_per_itemtype
- or item.onloan
- or item.itemlost
- or item.withdrawn
- or item.damaged
- or item.transfertwhen
- or item.reservedate
- ) %]
+ [% UNLESS ( item.itemnotforloan || item.notforloan_per_itemtype || item.onloan || item.itemlost || item.withdrawn || item.damaged || item.transfertwhen || item.reservedate ) %]