Bug 22343: (QA follow-up) Wrap email creation inside the try/catch block
authorTomas Cohen Arazi <tomascohen@theke.io>
Thu, 1 Oct 2020 14:28:59 +0000 (11:28 -0300)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 2 Oct 2020 08:54:41 +0000 (10:54 +0200)
commitf3f41caa6dd07d18db4e73216e3f58a92d826c3e
tree8675211a4ee4d3b96af0f11e4eee27ef3ade8879
parentf5def63c34af6fff84a561862eacc7189b6f6d4c
Bug 22343: (QA follow-up) Wrap email creation inside the try/catch block

At a later development stage, exceptions where added for bad addresses.
This wasn't addressed in the controllers.

This patch makes the basket and list sending controller scripts move
email creation inside the try/catch block to handle those situations. It
also UTF-8 encodes the attached marc.

On broadly testing this I found that if the TT templates that are used
to build the email contains non-latin characters, those get
double-encoded. So this patch also removes an explicit encoding that is
done, which colides with Email::MIME implicit encoding.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
basket/sendbasket.pl
opac/opac-sendbasket.pl
opac/opac-sendshelf.pl
virtualshelves/sendshelf.pl