Bug 17202: Don't report an item in a collection if the collection doesn't exist
authorNick Clemens <nick@bywatersolutions.com>
Wed, 7 Apr 2021 13:56:56 +0000 (13:56 +0000)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 28 Apr 2021 09:07:06 +0000 (11:07 +0200)
commite96c8439ffada76efe4eae5b1b13bf9a82640bd8
treea7ec7b052f1ed0bf2c00a060d56c3a094e504c31
parent0e5c00da4f2baf4f5eefb1e637982f4261638ce1
Bug 17202: Don't report an item in a collection if the collection doesn't exist

This simply adds a JOIN to the collections table - if the collection is gone
then the item is not considered to be in a rotating collection

Also remove variable to store the return that is not used later

To test:
Create a rotating collection
Add an item
Delete the rotating collection
View the db (SELECT * FROM collections_tracking;)
The item is still in the collection
Enable AutomaticItemReturn
Checkin the item at a branch not its home
The item does not get transferred home
Apply patch
Restart all the things
Check in the item, it is transferred home

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
C4/Circulation.pm
C4/RotatingCollections.pm