Bug 30642: Make renewal_type an enum in spec and add test
authorTomas Cohen Arazi <tomascohen@theke.io>
Fri, 10 Feb 2023 12:35:01 +0000 (09:35 -0300)
committerJacob O'Mara <jacob.omara@ptfs-europe.com>
Mon, 13 Feb 2023 09:29:38 +0000 (09:29 +0000)
commite84421e9e872657b60ba1a7a2d730b12b752def2
treecaffb78b85a9c630998572c945e0a514f5a50b02
parent2b116771f192e5c346897960f5ce5ad0e205a88b
Bug 30642: Make renewal_type an enum in spec and add test

This patch makes the renewal_type an enum, to match the change on the
DB. A test is added to account the fact the API is always setting
'Manual' request type.

Bonus: small portion of code gets a tidy, should've been asked by QA.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit c90f60adfcb3aeba3dd81122cce96db2c8d1fc1d)
Signed-off-by: Jacob O'Mara <jacob.omara@ptfs-europe.com>
C4/Circulation.pm
api/v1/swagger/definitions/renewal.yaml
t/db_dependent/api/v1/checkouts.t