Bug 28769: Remove tabloop from cataloguing plugins
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 20 Jul 2021 08:30:30 +0000 (10:30 +0200)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 18 Oct 2021 09:28:40 +0000 (11:28 +0200)
commitc66668b16cd8949e46f88a104870298ba013ed82
treef1dd7d9d4f7cebbd7dc21e0b52c68a17a7126371
parent6ae81043b794e9b5cb4bf2486d6f88b7917a397a
Bug 28769: Remove tabloop from cataloguing plugins

There is a "tabloop" variable that is passed from the add item form logic to the cataloguing plugins.
But there is confusion, sometimes it's an iterator ($i) and sometimes (batchMod.pl) an array.

Actually this tabloop variable is never used from cataloguing plugins, we should remove it.

Test plan:
Read the code and confirm the above.
You can also test a couple of plugins and confirm that they are still
working.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
58 files changed:
C4/Items.pm
Koha/FrameworkPlugin.pm
authorities/authorities.pl
cataloguing/addbiblio.pl
cataloguing/additem.pl
cataloguing/value_builder/unimarc_field_010.pl
cataloguing/value_builder/unimarc_field_100.pl
cataloguing/value_builder/unimarc_field_100_authorities.pl
cataloguing/value_builder/unimarc_field_105.pl
cataloguing/value_builder/unimarc_field_106.pl
cataloguing/value_builder/unimarc_field_110.pl
cataloguing/value_builder/unimarc_field_115a.pl
cataloguing/value_builder/unimarc_field_115b.pl
cataloguing/value_builder/unimarc_field_116.pl
cataloguing/value_builder/unimarc_field_117.pl
cataloguing/value_builder/unimarc_field_120.pl
cataloguing/value_builder/unimarc_field_121a.pl
cataloguing/value_builder/unimarc_field_121b.pl
cataloguing/value_builder/unimarc_field_122.pl
cataloguing/value_builder/unimarc_field_123a.pl
cataloguing/value_builder/unimarc_field_123d.pl
cataloguing/value_builder/unimarc_field_123e.pl
cataloguing/value_builder/unimarc_field_123f.pl
cataloguing/value_builder/unimarc_field_123g.pl
cataloguing/value_builder/unimarc_field_123i.pl
cataloguing/value_builder/unimarc_field_123j.pl
cataloguing/value_builder/unimarc_field_124.pl
cataloguing/value_builder/unimarc_field_124a.pl
cataloguing/value_builder/unimarc_field_124b.pl
cataloguing/value_builder/unimarc_field_124c.pl
cataloguing/value_builder/unimarc_field_124d.pl
cataloguing/value_builder/unimarc_field_124e.pl
cataloguing/value_builder/unimarc_field_124f.pl
cataloguing/value_builder/unimarc_field_124g.pl
cataloguing/value_builder/unimarc_field_125.pl
cataloguing/value_builder/unimarc_field_125a.pl
cataloguing/value_builder/unimarc_field_125b.pl
cataloguing/value_builder/unimarc_field_126.pl
cataloguing/value_builder/unimarc_field_126a.pl
cataloguing/value_builder/unimarc_field_126b.pl
cataloguing/value_builder/unimarc_field_127.pl
cataloguing/value_builder/unimarc_field_128a.pl
cataloguing/value_builder/unimarc_field_128b.pl
cataloguing/value_builder/unimarc_field_128c.pl
cataloguing/value_builder/unimarc_field_130.pl
cataloguing/value_builder/unimarc_field_135a.pl
cataloguing/value_builder/unimarc_field_140.pl
cataloguing/value_builder/unimarc_field_141.pl
cataloguing/value_builder/unimarc_field_210c.pl
cataloguing/value_builder/unimarc_field_210c_bis.pl
cataloguing/value_builder/unimarc_field_225a.pl
cataloguing/value_builder/unimarc_field_225a_bis.pl
cataloguing/value_builder/unimarc_field_4XX.pl
cataloguing/value_builder/unimarc_field_686a.pl
cataloguing/value_builder/unimarc_field_700-4.pl
cataloguing/value_builder/unimarc_leader.pl
t/db_dependent/FrameworkPlugin.t
tools/batchMod.pl