Bug 22042: Block all return actions when BlockReturnOfWithdrawn items is set to block
authorNick Clemens <nick@bywatersolutions.com>
Fri, 8 Apr 2022 18:52:09 +0000 (18:52 +0000)
committerArthur Suzuki <arthur.suzuki@biblibre.com>
Thu, 26 Jan 2023 13:55:04 +0000 (14:55 +0100)
commitc0fa919492cb41fa99084eab7b20f599d7c78274
treee38c0f4a71689cae91c336203fa87b1668933553
parentb23df4c8c0b8239a507cc4ca1e2ba94af057d5f3
Bug 22042: Block all return actions when BlockReturnOfWithdrawn items is set to block

Currently this syspref only bokcs the literal 'return' from a patron, i.e. the checkin

It still processes transfers, refunds lost items, updates NotForLoan status etc.

We should block all of these things

To test:
1 - Set BlockReturnOfWithdrawn to block
2 - Set an item as lost and withdrawn
3 - Check it in
4 - Item is found
5 - Apply patch
6 - Repeat 1-3
7 - Checkin is blocked, item still lost

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 321d8f7ce677bf4feb6b3946ad652d6921ca6bea)
Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com>
C4/Circulation.pm
t/db_dependent/Circulation.t