Bug 17950: Merge.t: Improve variable handling at top level
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Mon, 23 Jan 2017 10:40:48 +0000 (11:40 +0100)
committerKyle M Hall <kyle@bywatersolutions.com>
Fri, 17 Feb 2017 11:41:48 +0000 (11:41 +0000)
commit849877d8d3bcd3791c624a84ec5e4cb0550fa0fe
treefb3c86b1629f3c73cced3753228b2808f058a29a
parent5d279befed1b6faf829ab0ebd19357dbfc7c576e
Bug 17950: Merge.t: Improve variable handling at top level

This patch does:
[1] Remove unused $dbh.
[2] Move all mocking statements to one sub.
[3] Promote a few lexicals to globals when used in the subtests.

Test plan:
Run t/db_dependent/Authorities/Merge.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
t/db_dependent/Authorities/Merge.t