Bug 12065: use encode_qp consistently when sending basket/shelf
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Thu, 10 Apr 2014 12:40:01 +0000 (14:40 +0200)
committerGalen Charlton <gmc@esilibrary.com>
Fri, 9 May 2014 15:14:40 +0000 (15:14 +0000)
commit76e8bb0fabd4a9ef85fd2dc5ad604c446a50f751
tree1c6bd9a08897796e86a3aa032e82b0f31de5b196
parent31781ffb02c3a806e0956ca07dfc24beab0b88dd
Bug 12065: use encode_qp consistently when sending basket/shelf

QP-encode both mail header and mail body when sending baskets or
shelves.  There is no need to Encode qp-encoded strings.

Note that this does not solve all possible encoding problems in the mail
sent. This is related to decoding CGI parameters and use of TT. That
problem is addressed in bug 11944.

Test plan:
Verify if sending a basket from opac and staff still works.
Check if sending a shelf (list) from opac and staff still functions as
expected.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Cart/List sent form opac/staff works
No koha-qa errors

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
basket/sendbasket.pl
opac/opac-sendbasket.pl
opac/opac-sendshelf.pl
virtualshelves/sendshelf.pl