Bug 31459: Use the same dropdown as when adding orders to a basket
authorNick Clemens <nick@bywatersolutions.com>
Thu, 25 Aug 2022 11:26:33 +0000 (11:26 +0000)
committerArthur Suzuki <arthur.suzuki@biblibre.com>
Fri, 16 Dec 2022 15:50:30 +0000 (16:50 +0100)
commit69e2d1e9c0945e5f0a1fa41c5020dfc6c5ec3157
tree5f62ca54ee9e6d5f077d26c69aa2eae5bce9b91b
parentc8208746582ec7b262ee4e0201e1a5aed58269eb
Bug 31459: Use the same dropdown as when adding orders to a basket

Current order receive code loops over each budget period and gets the hierarchy, this
is slow when systems have many budgets. Additionally, the list includes inactive items
by default

We can switch to a single call, and add consistency by adopting the same dropdown as used
when placing an order

To test:
1 - Add some budgets with funds - ensure you have at least one inactive budget and fund
2 - Place an order, observe the fund selection menu
3 - Close basket, receive order, observe the fund menu
4 - Apply patch
5 - Cancel receipt
6 - Receive again
7 - Observe fund menu, confirm it matches the order placing menu
8 - Confirm inactive are not displayed by default, but are when button is checked

Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
https://bugs.koha-community.org/show_bug.cgi?id=31559
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 24e7703aef42b2e9e7900dc36eb5c8f1d3f73e4f)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 382e80b7377f2f000b4ae94f4526b608ed80fe71)
Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com>
acqui/orderreceive.pl
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt