Bug 31250: Deny clearing cookies with numeric suffix
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Thu, 28 Jul 2022 12:43:20 +0000 (12:43 +0000)
committerLucas Gass <lucas@bywatersolutions.com>
Mon, 31 Oct 2022 20:44:29 +0000 (20:44 +0000)
commit58eb3713ec64c35010c663827f943de7b4b9f0da
tree5b15a1c252468d08edd3d6ceffe3ad9f2e4cd574
parentaf028799dcf2e77bc48a20ba6620134d83479abb
Bug 31250: Deny clearing cookies with numeric suffix

This change allows us to add catalogue_editor_ to the deny list
in koha-conf.xml and keep cookies like catalogue_editor_123.

Test plan:
Run t/CookieManager.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
To test:
1 - Sign in to staff client
2 - Search for records and edit one
3 - Switch to advanced editor
4 - View cookies (F12/developer panel/storage tab)
5 - Note cookie like 'catalogue_editor_##' with value 'advanced'
6 - Log out
7 - note cookie value deleted
8 - Log in and search/edit a record
9 - Basic editor loads
10 - Apply patch
11 - Add line to koha-conf as described in second patch
12 - Restart all
13 - Switch to advanced editor
14 - Cookie value updated
15 - Logout
16 - Cookie value remains
17 - Log in and search/edit
18 - Confirm advanced editor loads

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit cb036faf2c534a14708b517cea40d98fc6e344c2)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Koha/CookieManager.pm
t/CookieManager.t