Bug 28606: Remove $DEBUG and $ENV{DEBUG}
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 22 Jun 2021 10:54:15 +0000 (12:54 +0200)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 24 Jun 2021 09:53:44 +0000 (11:53 +0200)
commit41a8005d1013815d312089c00e9e5464768e1332
tree142be0f12510a5954b3c89af7cc838325430330d
parentfeb09b1cc28e530fba86cfe2b53e8d0bde1f9d5b
Bug 28606: Remove $DEBUG and $ENV{DEBUG}

We should remove the debug statements or use Koha::Logger when we want
to keep it.

Test plan:
Confirm that occurrences of remaining occurrences of DEBUG need to be
kept (historical scripts for instance)
Confirm that the occurrences removed by this patch can be removed
Confirm that the occurrences replaced by Koha::Logger are correct

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Looks good to me, noting a few minor points on BZ.

JD amended patch: replace "warn #Finished" with "#warn Finished", and
put the statement on a single line

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
49 files changed:
C4/Auth.pm
C4/Auth_with_cas.pm
C4/Auth_with_ldap.pm
C4/Auth_with_shibboleth.pm
C4/CourseReserves.pm
C4/Koha.pm
C4/Languages.pm
C4/MarcModificationTemplates.pm
C4/Members.pm
C4/Members/Statistics.pm
C4/Patroncards/Patroncard.pm
C4/SIP/ILS.pm
C4/SIP/ILS/Transaction/FeePayment.pm
C4/SIP/Sip/Checksum.pm
C4/Service.pm
Koha/Cache.pm
Koha/Cache/Object.pm
Koha/SimpleMARC.pm
Koha/XSLT/Base.pm
catalogue/detail.pl
catalogue/image.pl
cataloguing/value_builder/barcode.pl
cataloguing/value_builder/barcode_manual.pl
circ/hold-transfer-slip.pl
circ/transfer-slip.pl
fix-perl-path.PL
installer/data/mysql/updatedatabase.pl
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
labels/label-edit-batch.pl
labels/label-manage.pl
members/memberentry.pl
members/moremember.pl
members/patronimage.pl
members/printslip.pl
misc/cronjobs/staticfines.pl
misc/maintenance/UNIMARC_sync_date_created_with_marc_biblio.pl
misc/migration_tools/koha-svc.pl
offline_circ/enqueue_koc.pl
offline_circ/process_koc.pl
opac/opac-image.pl
opac/opac-search.pl
patroncards/edit-batch.pl
patroncards/manage.pl
t/Auth.t
t/db_dependent/00-strict.t
t/db_dependent/Circulation/dateexpiry.t
t/db_dependent/Context.t
tools/scheduler.pl
tools/upload-cover-image.pl