Bug 18448: Fix a few db_dependent tests
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Sun, 16 Apr 2017 16:50:58 +0000 (18:50 +0200)
committerKyle M Hall <kyle@bywatersolutions.com>
Fri, 21 Apr 2017 00:09:43 +0000 (00:09 +0000)
commit2ba4a661d38c856ff10c9bcf1680f6619bdab2cd
tree345f2e54793a972a9abc63bfeead43af0cb8dd6e
parentd0a37bb8bfdb8f426f83920314179b207be496fd
Bug 18448: Fix a few db_dependent tests

Tests in db_dependent may expect a Koha database, but should not rely on
hardcoded categories, currencies, branch codes, etc.

This patch fixes a bunch of those. But this is a continuous project. We also
need QA to closely watch new edits.

Accounts.t: hardcoded category PT replaced
Acquisition/OrderFromSubscription.t: hardcoded USD
Acquisition/StandingOrders.t: same
ArticleRequests.t: create itemtype, branch and category for testing
AuthorisedValues.t: remove $dbh, add two test branches
AuthoritiesMarc.t: add hardcoded GEOGR_NAME authtype
Bookseller.t: add test currency
Koha.t: add test itemtype instead of hardcoded BK
UsageStats.t: add test branch and category

Test plan:
Run the adjusted tests.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
All tests successful (see comment #9)
Signed-off-by: Marc VĂ©ron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
t/db_dependent/Accounts.t
t/db_dependent/Acquisition/OrderFromSubscription.t
t/db_dependent/Acquisition/StandingOrders.t
t/db_dependent/ArticleRequests.t
t/db_dependent/AuthorisedValues.t
t/db_dependent/AuthoritiesMarc.t
t/db_dependent/Bookseller.t
t/db_dependent/Koha.t
t/db_dependent/UsageStats.t