Bug 29705: In test suite merge IssuingRules with CirculationRules
authorFridolin Somers <fridolin.somers@biblibre.com>
Wed, 15 Dec 2021 21:19:21 +0000 (11:19 -1000)
committerFridolin Somers <fridolin.somers@biblibre.com>
Fri, 6 May 2022 20:33:10 +0000 (10:33 -1000)
commit21e03340c62f5ed4101e2077600a98af30dd1a01
tree56629ddc29efe0e1f82cd558642687dc3e935f38
parent1501ff325971a30b516e28b6fe14c2ced58fa2be
Bug 29705: In test suite merge IssuingRules with CirculationRules

After Bug 18936, in test suite, there is still t/db_dependent/Koha/IssuingRules.t and t/db_dependent/Koha/IssuingRules/
This patch moves IssuingRules.t inside CirculationRules.t and renames dir t/db_dependent/Koha/IssuingRules.
And adds DB transation in each first-level subtest.

Also renames in :
  use constant GUESSED_ITEMTYPES_KEY => 'Koha_IssuingRules_last_guess';

Test plan :
Run prove t/db_dependent/Koha/CirculationRules.t
prove t/db_dependent/Koha/CirculationRules/*
prove t/db_dependent/Circulation/maxsuspensiondays.t

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Koha/CirculationRules.pm
t/db_dependent/Circulation/IssuingRules/maxsuspensiondays.t [deleted file]
t/db_dependent/Circulation/maxsuspensiondays.t [new file with mode: 0755]
t/db_dependent/Koha/CirculationRules.t
t/db_dependent/Koha/CirculationRules/guess_article_requestable_itemtypes.t [new file with mode: 0755]
t/db_dependent/Koha/IssuingRules.t [deleted file]
t/db_dependent/Koha/IssuingRules/guess_article_requestable_itemtypes.t [deleted file]