X-Git-Url: http://koha-dev.rot13.org:8081/gitweb/?a=blobdiff_plain;f=t%2FBiblio.t;h=c298349e18f1470b27e9af566cf930d7a9355e5c;hb=b96e61f1eaec6db55461c17e81fbfbe9f5321aff;hp=67f752d4c5663e8b71517892df7a282105dc8935;hpb=de8d5f3ae91049252edeabe61e2cbe1d300a999b;p=srvgit

diff --git a/t/Biblio.t b/t/Biblio.t
index 67f752d4c5..c298349e18 100755
--- a/t/Biblio.t
+++ b/t/Biblio.t
@@ -17,12 +17,17 @@
 
 use Modern::Perl;
 
-use Test::More tests => 44;
+use Test::More;
+use Test::MockModule;
 use Test::Warn;
 
-BEGIN {
-        use_ok('C4::Biblio');
-}
+plan tests => 34;
+
+
+use_ok('C4::Biblio', qw( AddBiblio ModBiblio BiblioAutoLink LinkBibHeadingsToAuthorities GetMarcPrice GetMarcQuantity GetMarcControlnumber GetMarcISBN GetMarcISSN GetMarcSubjects GetMarcUrls GetMarcSeries TransformMarcToKoha ModBiblioMarc RemoveAllNsb UpdateTotalIssues ));
+
+my $db = Test::MockModule->new('Koha::Database');
+$db->mock( _new_schema => sub { return Schema(); } );
 
 my @arr;
 my $ret;
@@ -47,24 +52,12 @@ warning_is { $ret = BiblioAutoLink(undef, q{}) }
 
 is( $ret, 0, 'BiblioAutoLink returns zero if not passed rec');
 
-warning_is { $ret = GetRecordValue('100', undef, q{}) }
-           { carped => 'GetRecordValue called with undefined record'},
-           "GetRecordValue returns carped warning on undef record";
-
-ok( !defined $ret, 'GetRecordValue returns undef if not passed rec');
-
 warning_is { @arr = LinkBibHeadingsToAuthorities(q{}, q{}) }
            { carped => 'LinkBibHeadingsToAuthorities called on undefined bib record'},
            "LinkBibHeadingsToAuthorities returns carped warning on undef record";
 
 is($arr[0], 0, 'LinkBibHeadingsToAuthorities correct error return');
 
-warning_is { $ret = GetCOinSBiblio() }
-           { carped => 'GetCOinSBiblio called with undefined record'},
-           "GetCOinSBiblio returns carped warning on undef record";
-
-ok( !defined $ret, 'GetCOinSBiblio returns undef if not passed rec');
-
 warning_is { $ret = GetMarcPrice(undef, 'MARC21') }
            { carped => 'GetMarcPrice called on undefined record'},
            "GetMarcPrice returns carped warning on undef record";
@@ -95,24 +88,12 @@ warning_is { $ret = GetMarcISSN() }
 
 ok( !defined $ret, 'GetMarcISSN returns undef if not passed rec');
 
-warning_is { $ret = GetMarcNotes() }
-           { carped => 'GetMarcNotes called on undefined record'},
-           "GetMarcNotes returns carped warning on undef record";
-
-ok( !defined $ret, 'GetMarcNotes returns undef if not passed rec');
-
 warning_is { $ret = GetMarcSubjects() }
            { carped => 'GetMarcSubjects called on undefined record'},
            "GetMarcSubjects returns carped warning on undef record";
 
 ok( !defined $ret, 'GetMarcSubjects returns undef if not passed rec');
 
-warning_is { $ret = GetMarcAuthors() }
-           { carped => 'GetMarcAuthors called on undefined record'},
-           "GetMarcAuthors returns carped warning on undef record";
-
-ok( !defined $ret, 'GetMarcAuthors returns undef if not passed rec');
-
 warning_is { $ret = GetMarcUrls() }
            { carped => 'GetMarcUrls called on undefined record'},
            "GetMarcUrls returns carped warning on undef record";
@@ -125,15 +106,9 @@ warning_is { $ret = GetMarcSeries() }
 
 ok( !defined $ret, 'GetMarcSeries returns undef if not passed rec');
 
-warning_is { $ret = GetMarcHosts() }
-           { carped => 'GetMarcHosts called on undefined record'},
-           "GetMarcHosts returns carped warning on undef record";
-
-ok( !defined $ret, 'GetMarcHosts returns undef if not passed rec');
-
 my $hash_ref;
 
-warning_is { $hash_ref = TransformMarcToKoha(undef, undef) }
+warning_is { $hash_ref = TransformMarcToKoha( undef) }
            { carped => 'TransformMarcToKoha called with undefined record'},
            "TransformMarcToKoha returns carped warning on undef record";
 
@@ -155,10 +130,10 @@ warning_is { $ret = RemoveAllNsb() }
 
 ok( !defined $ret, 'RemoveAllNsb returns undef if not passed rec');
 
-warning_is { $ret = UpdateTotalIssues() }
-           { carped => 'UpdateTotalIssues could not get biblio record'},
-           "UpdateTotalIssues returns carped warning if biblio record does not exist";
 
-ok( !defined $ret, 'UpdateTotalIssues returns carped warning if biblio record does not exist');
+warnings_like { $ret = UpdateTotalIssues() }
+              [
+                { carped => qr/UpdateTotalIssues could not get biblio/ } ],
+    "UpdateTotalIssues returns carped warnings if biblio record does not exist";
 
-1;
+ok( !defined $ret, 'UpdateTotalIssues returns carped warning if biblio record does not exist');