X-Git-Url: http://koha-dev.rot13.org:8081/gitweb/?a=blobdiff_plain;f=t%2FBiblio.t;h=c298349e18f1470b27e9af566cf930d7a9355e5c;hb=a11633379f8d9f6a933da7fa887b2e7966e3765a;hp=4ade7cc917073ff9c0226f95e354100cf58334c6;hpb=d5986c9b972e6634fbc3f52e544316ed607eb502;p=koha-ffzg.git diff --git a/t/Biblio.t b/t/Biblio.t index 4ade7cc917..c298349e18 100755 --- a/t/Biblio.t +++ b/t/Biblio.t @@ -21,30 +21,10 @@ use Test::More; use Test::MockModule; use Test::Warn; -use Module::Load::Conditional qw/check_install/; - -BEGIN { - if ( check_install( module => 'Test::DBIx::Class' ) ) { - plan tests => 47; - } else { - plan skip_all => "Need Test::DBIx::Class" - } -} - -use_ok('C4::Biblio'); - -#use Test::DBIx::Class {}, 'Biblio'; -use Test::DBIx::Class; #No difference between these two invocations in time taken to execute tests. - -sub fixtures { - my ( $data ) = @_; - fixtures_ok [ - Biblio => [ - [ qw/ biblionumber datecreated timestamp / ], - @$data, - ], - ], 'add fixtures'; -} +plan tests => 34; + + +use_ok('C4::Biblio', qw( AddBiblio ModBiblio BiblioAutoLink LinkBibHeadingsToAuthorities GetMarcPrice GetMarcQuantity GetMarcControlnumber GetMarcISBN GetMarcISSN GetMarcSubjects GetMarcUrls GetMarcSeries TransformMarcToKoha ModBiblioMarc RemoveAllNsb UpdateTotalIssues )); my $db = Test::MockModule->new('Koha::Database'); $db->mock( _new_schema => sub { return Schema(); } ); @@ -72,24 +52,12 @@ warning_is { $ret = BiblioAutoLink(undef, q{}) } is( $ret, 0, 'BiblioAutoLink returns zero if not passed rec'); -warning_is { $ret = GetRecordValue('100', undef, q{}) } - { carped => 'GetRecordValue called with undefined record'}, - "GetRecordValue returns carped warning on undef record"; - -ok( !defined $ret, 'GetRecordValue returns undef if not passed rec'); - warning_is { @arr = LinkBibHeadingsToAuthorities(q{}, q{}) } { carped => 'LinkBibHeadingsToAuthorities called on undefined bib record'}, "LinkBibHeadingsToAuthorities returns carped warning on undef record"; is($arr[0], 0, 'LinkBibHeadingsToAuthorities correct error return'); -warning_is { $ret = GetCOinSBiblio() } - { carped => 'GetCOinSBiblio called with undefined record'}, - "GetCOinSBiblio returns carped warning on undef record"; - -ok( !defined $ret, 'GetCOinSBiblio returns undef if not passed rec'); - warning_is { $ret = GetMarcPrice(undef, 'MARC21') } { carped => 'GetMarcPrice called on undefined record'}, "GetMarcPrice returns carped warning on undef record"; @@ -120,24 +88,12 @@ warning_is { $ret = GetMarcISSN() } ok( !defined $ret, 'GetMarcISSN returns undef if not passed rec'); -warning_is { $ret = GetMarcNotes() } - { carped => 'GetMarcNotes called on undefined record'}, - "GetMarcNotes returns carped warning on undef record"; - -ok( !defined $ret, 'GetMarcNotes returns undef if not passed rec'); - warning_is { $ret = GetMarcSubjects() } { carped => 'GetMarcSubjects called on undefined record'}, "GetMarcSubjects returns carped warning on undef record"; ok( !defined $ret, 'GetMarcSubjects returns undef if not passed rec'); -warning_is { $ret = GetMarcAuthors() } - { carped => 'GetMarcAuthors called on undefined record'}, - "GetMarcAuthors returns carped warning on undef record"; - -ok( !defined $ret, 'GetMarcAuthors returns undef if not passed rec'); - warning_is { $ret = GetMarcUrls() } { carped => 'GetMarcUrls called on undefined record'}, "GetMarcUrls returns carped warning on undef record"; @@ -150,12 +106,6 @@ warning_is { $ret = GetMarcSeries() } ok( !defined $ret, 'GetMarcSeries returns undef if not passed rec'); -warning_is { $ret = GetMarcHosts() } - { carped => 'GetMarcHosts called on undefined record'}, - "GetMarcHosts returns carped warning on undef record"; - -ok( !defined $ret, 'GetMarcHosts returns undef if not passed rec'); - my $hash_ref; warning_is { $hash_ref = TransformMarcToKoha( undef) } @@ -180,20 +130,10 @@ warning_is { $ret = RemoveAllNsb() } ok( !defined $ret, 'RemoveAllNsb returns undef if not passed rec'); -warning_is { $ret = GetMarcBiblio() } - { carped => 'GetMarcBiblio called without parameters'}, - "GetMarcBiblio returns carped warning on no parameters"; - -warning_is { $ret = GetMarcBiblio({ biblionumber => undef }) } - { carped => 'GetMarcBiblio called with undefined biblionumber'}, - "GetMarcBiblio returns carped warning on undef biblionumber"; - -ok( !defined $ret, 'GetMarcBiblio returns undef if not passed a biblionumber'); warnings_like { $ret = UpdateTotalIssues() } - [ { carped => qr/GetMarcBiblio called with undefined biblionumber/ }, - { carped => qr/UpdateTotalIssues could not get biblio record/ } ], + [ + { carped => qr/UpdateTotalIssues could not get biblio/ } ], "UpdateTotalIssues returns carped warnings if biblio record does not exist"; ok( !defined $ret, 'UpdateTotalIssues returns carped warning if biblio record does not exist'); -