X-Git-Url: http://koha-dev.rot13.org:8081/gitweb/?a=blobdiff_plain;f=reports%2Fcat_issues_top.pl;h=22b88ae017b368efaf243b54657663c2515994d8;hb=8e442955247e925dacf303455f40522a89a349b2;hp=f134b9a7127e5b74ef5ae729ff1de39f81925c66;hpb=da1085ccfa587fb8075fe33125060a54ceda6c97;p=koha_fer diff --git a/reports/cat_issues_top.pl b/reports/cat_issues_top.pl index f134b9a712..22b88ae017 100755 --- a/reports/cat_issues_top.pl +++ b/reports/cat_issues_top.pl @@ -14,11 +14,12 @@ # WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR # A PARTICULAR PURPOSE. See the GNU General Public License for more details. # -# You should have received a copy of the GNU General Public License along with -# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place, -# Suite 330, Boston, MA 02111-1307 USA +# You should have received a copy of the GNU General Public License along +# with Koha; if not, write to the Free Software Foundation, Inc., +# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; @@ -48,22 +49,22 @@ my $column = $input->param("Criteria"); my @filters = $input->param("Filter"); $filters[0]=format_date_in_iso($filters[0]); $filters[1]=format_date_in_iso($filters[1]); +$filters[2]=format_date_in_iso($filters[2]); +$filters[3]=format_date_in_iso($filters[3]); my $output = $input->param("output"); my $basename = $input->param("basename"); -my $mime = $input->param("MIME"); #warn "calcul : ".$calc; my ($template, $borrowernumber, $cookie) = get_template_and_user({template_name => $fullreportname, query => $input, type => "intranet", authnotrequired => 0, - flagsrequired => { reports => 1}, + flagsrequired => { reports => '*'}, debug => 1, }); our $sep = $input->param("sep"); $sep = "\t" if ($sep eq 'tabulation'); $template->param(do_it => $do_it, - DHTMLcalendar_dateformat => C4::Dates->DHTMLcalendar(), ); if ($do_it) { # Displaying results @@ -73,7 +74,7 @@ if ($do_it) { $template->param(mainloop => $results, limit => $limit); output_html_with_http_headers $input, $cookie, $template->output; - exit(1); + exit; } else { # Printing to a csv file print $input->header(-type => 'application/vnd.sun.xml.calc', @@ -106,7 +107,7 @@ if ($do_it) { print $sep.$col->{totalcol}; } print $sep.@$results[0]->{total}; - exit(1); + exit; } # Displaying choices } else { @@ -116,39 +117,21 @@ if ($do_it) { my %select; my $req; - my @mime = ( C4::Context->preference("MIME") ); -# foreach my $mime (@mime){ -# warn "".$mime; -# } - my $CGIextChoice=CGI::scrolling_list( -name => 'MIME', -id => 'MIME', - -values => \@mime, + -values => ['CSV'], # FIXME translation -size => 1, -multiple => 0 ); my $CGIsepChoice=GetDelimiterChoices; - #branch - my $branches = GetBranches; - my @branchloop; - foreach my $thisbranch (keys %$branches) { -# my $selected = 1 if $thisbranch eq $branch; - my %row =(value => $thisbranch, -# selected => $selected, - branchname => $branches->{$thisbranch}->{'branchname'}, - ); - push @branchloop, \%row; - } #doctype my $itemtypes = GetItemTypes; my @itemtypeloop; - foreach my $thisitemtype (keys %$itemtypes) { -# my $selected = 1 if $thisbranch eq $branch; + foreach my $thisitemtype ( sort {$itemtypes->{$a}->{'description'} cmp $itemtypes->{$b}->{'description'}} keys %$itemtypes) { my %row =(value => $thisitemtype, -# selected => $selected, - description => $itemtypes->{$thisitemtype}->{'description'}, + description => $itemtypes->{$thisitemtype}->{'description'}, ); push @itemtypeloop, \%row; } @@ -156,11 +139,9 @@ if ($do_it) { #borcat my ($codes,$labels) = GetborCatFromCatType(undef,undef); my @borcatloop; - foreach my $thisborcat (sort keys %$labels) { -# my $selected = 1 if $thisbranch eq $branch; + foreach my $thisborcat (sort {$labels->{$a} cmp $labels->{$b}} keys %$labels) { my %row =(value => $thisborcat, -# selected => $selected, - description => $labels->{$thisborcat}, + description => $labels->{$thisborcat}, ); push @borcatloop, \%row; } @@ -170,7 +151,7 @@ if ($do_it) { $template->param( CGIextChoice => $CGIextChoice, CGIsepChoice => $CGIsepChoice, - branchloop =>\@branchloop, + branchloop => GetBranchesLoop(C4::Context->userenv->{'branch'}), itemtypeloop =>\@itemtypeloop, borcatloop =>\@borcatloop, ); @@ -224,7 +205,9 @@ sub calculate { my $colorder; if ($column){ $column = "old_issues.".$column if (($column=~/branchcode/) or ($column=~/timestamp/)); - $column = "biblioitems.".$column if $column=~/itemtype/; + if($column=~/itemtype/){ + $column = C4::Context->preference('item-level_itypes') ? "items.itype": "biblioitems.itemtype"; + } $column = "borrowers.".$column if $column=~/categorycode/; my @colfilter ; $colfilter[0] = @$filters[0] if ($column =~ /timestamp/ ) ; @@ -282,7 +265,6 @@ sub calculate { } $strsth2 .=" group by $colfield"; $strsth2 .=" order by $colorder"; - warn "". $strsth2; my $sth2 = $dbh->prepare( $strsth2 ); if (( @colfilter ) and ($colfilter[1])){ @@ -325,11 +307,10 @@ sub calculate { $strcalc .= "SELECT DISTINCT biblio.title, COUNT(biblio.biblionumber) AS RANK, biblio.biblionumber AS ID"; $strcalc .= " , $colfield " if ($colfield); $strcalc .= " FROM `old_issues` - LEFT JOIN borrowers ON old_issues.borrowernumber=borrowers.borrowernumber - LEFT JOIN (items - LEFT JOIN biblioitems ON biblioitems.biblioitemnumber=items.biblioitemnumber) - ON items.itemnumber=old_issues.itemnumber - LEFT JOIN biblio ON (biblio.biblionumber=items.biblionumber) + LEFT JOIN items USING(itemnumber) + LEFT JOIN biblio USING(biblionumber) + LEFT JOIN biblioitems USING(biblionumber) + LEFT JOIN borrowers USING(borrowernumber) WHERE 1"; @$filters[0]=~ s/\*/%/g if (@$filters[0]); @@ -343,7 +324,14 @@ sub calculate { @$filters[4]=~ s/\*/%/g if (@$filters[4]); $strcalc .= " AND old_issues.branchcode like '" . @$filters[4] ."'" if ( @$filters[4] ); @$filters[5]=~ s/\*/%/g if (@$filters[5]); - $strcalc .= " AND biblioitems.itemtype like '" . @$filters[5] ."'" if ( @$filters[5] ); + if ( @$filters[5] ){ + if(C4::Context->preference('item-level_itypes') ){ + $strcalc .= " AND items.itype like " + }else{ + $strcalc .= " AND biblioitems.itemtype like " + } + $strcalc .= "'" . @$filters[5] ."'" ; + } @$filters[6]=~ s/\*/%/g if (@$filters[6]); $strcalc .= " AND borrowers.categorycode like '" . @$filters[6] ."'" if ( @$filters[6] ); @$filters[7]=~ s/\*/%/g if (@$filters[7]); @@ -357,17 +345,9 @@ sub calculate { $strcalc .= ", $colfield" if ($column); $strcalc .= " order by RANK DESC"; $strcalc .= ", $colfield " if ($colfield); - -# my $max; -# if (@loopcol) { -# $max = $line*@loopcol; -# } else { $max=$line;} -# $strcalc .= " LIMIT 0,$max"; - warn "SQL :". $strcalc; my $dbcalc = $dbh->prepare($strcalc); $dbcalc->execute; -# warn "filling table"; my $previous_col; my %indice; while (my @data = $dbcalc->fetchrow) { @@ -377,7 +357,6 @@ sub calculate { $table[$indice{$col}]->{$col}->{'name'}=$row; $table[$indice{$col}]->{$col}->{'count'}=$rank; $table[$indice{$col}]->{$col}->{'link'}=$id; -# warn " ".$i." ".$col. " ".$row; $indice{$col}++; } @@ -385,12 +364,10 @@ sub calculate { for ($i=1; $i<=$line;$i++) { my @loopcell; - warn " $i"; #@loopcol ensures the order for columns is common with column titles # and the number matches the number of columns my $colcount=0; foreach my $col ( @loopcol ) { -# warn " colonne :$col->{coltitle}"; my $value; my $count=0; my $link; @@ -403,15 +380,12 @@ sub calculate { $count =$table[$i]->{"zzEMPTY"}->{'count'}; $link =$table[$i]->{"zzEMPTY"}->{'link'}; } -# warn " ".$i ." value:$value count:$count reference:$link"; push @loopcell, {value => $value, count =>$count, reference => $link} ; } - #warn "row : $row colcount:$colcount"; #my $total = $table[$i]->{totalrow}/$colcount if ($colcount>0); push @looprow,{ 'rowtitle' => $i , 'loopcell' => \@loopcell, 'hilighted' => ($hilighted >0), - #'totalrow' => ($total)?sprintf("%.2f",$total):0 }; $hilighted = -$hilighted; }